Skip to content
  • ThibG's avatar
    Twidere mention workaround (#5552) · 5d5c0f4f
    ThibG authored
    * Work around Twidere and Tootdon bug
    
    Tootdon and Twidere construct @user@domain handles from mentions in toots based
    solely on the mention text and account URI's domain without performing any
    webfinger call or retrieving account info from the Mastodon server.
    
    As a result, when a remote user has WEB_DOMAIN ≠ LOCAL_DOMAIN, Twidere and
    Tootdon will construct the mention as @user@WEB_DOMAIN. Now, this will usually
    resolve to the correct account (since the recommended configuration is to have
    WEB_DOMAIN perform webfinger redirections to LOCAL_DOMAIN) when processing
    mentions, but won't do so when displaying them (as it does not go through the
    whole account resolution at that time).
    
    This change rewrites mentions to the resolved account, so that displaying the
    mentions will work.
    
    * Use lookbehind instead of non-capturing group in MENTION_RE
    
    Indeed, substitutions with the previous regexp would erroneously eat any
    preceding whitespace, which would lead to concatenated mentions in the
    previous commit.
    
    Note that users will “lose” up to one character space per mention for their
    toots, as that regexp is also used to remove the domain-part of mentioned
    users for character counting purposes, and it also erroneously removed the
    preceding character if it was a space.
    5d5c0f4f