pleroma-elixir-libraries/linkify
0
0
Fork 1
Code Issues 9 Pull requests 3 Projects Releases Packages Wiki Activity

URLs with IPv6 addresses #25

New issue
Open
opened 2020-11-19 22:38:57 +00:00 by feld · 1 comment
feld commented 2020-11-19 22:38:57 +00:00
Owner
Copy link

Not sure how many variations we want to support, but at a minimum I think we should be able to correctly link with scheme like so:

Bare IPv6 addresses with or without the square brackets would be nice, but probably not worth it. Then we have to make sure we aren't linking an address/prefix... headaches galore. We already have a neat problem with #17

It's funny that GitLab doesn't get this correct either :)

Not sure how many variations we want to support, but at a minimum I think we should be able to correctly link with scheme like so: - http://[2001:db8::1:0] - http://[2001:db8::1:0]:4000 Bare IPv6 addresses with or without the square brackets would be nice, but probably not worth it. Then we have to make sure we aren't linking an `address/prefix`... headaches galore. We already have a neat problem with #17 It's funny that GitLab doesn't get this correct either :)
feld commented 2020-12-21 20:07:59 +00:00
Author
Owner
Copy link

I started down this path, but it's quite complicated. We try to do too much with the regex @match_url which is the core of the problem.

We also fail in valid_tld? because IPv6 addresses have colons and we exclude those from valid "hosts" in @get_scheme_host.

Additionally, successfully detecting condensed form addresses like 2607:dba::1 gets tricky even before we add support for the square-bracket format.

I started down this path, but it's quite complicated. We try to do too much with the regex `@match_url` which is the core of the problem. We also fail in `valid_tld?` because IPv6 addresses have colons and we exclude those from valid "hosts" in `@get_scheme_host`. Additionally, successfully detecting condensed form addresses like `2607:dba::1` gets tricky even before we add support for the square-bracket format.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
gitlab-mr-iid-55
parsing-fixes
gitlab-mr-iid-53
gitlab-mr-iid-54
release/0.5.3
gitlab-mr-iid-50
gitlab-mr-iid-52
tusooa/doubledotlink
gitlab-mr-iid-51
tusooa/zwnj=nobrk
gitlab-mr-iid-49
2022-03-deps
gitlab-mr-iid-47
gitlab-mr-iid-48
gitlab-mr-iid-46
release-0.5.2
gitlab-mr-iid-45
0.5.1
gitlab-mr-iid-44
gitlab-mr-iid-43
gitlab-mr-iid-42
release/0.5.0
gitlab-mr-iid-41
test/local-tlds
gitlab-mr-iid-38
gitlab-mr-iid-40
gitlab-mr-iid-39
gitlab-mr-iid-37
gitlab-mr-iid-36
release/0.4.1
fix/address-parsing
gitlab-mr-iid-35
gitlab-mr-iid-34
release/0.4.0
gitlab-mr-iid-33
ipv6
gitlab-mr-iid-32
gitlab-mr-iid-29
gitlab-mr-iid-31
gitlab-mr-iid-30
gitlab-mr-iid-28
gitlab-mr-iid-26
release-0.3.0
gitlab-mr-iid-27
gitlab-mr-iid-24
gitlab-mr-iid-25
gitlab-mr-iid-23
gitlab-mr-iid-22
gitlab-mr-iid-21
gitlab-mr-iid-20
gitlab-mr-iid-19
gitlab-mr-iid-18
gitlab-mr-iid-17
gitlab-mr-iid-16
gitlab-mr-iid-15
gitlab-mr-iid-13
gitlab-mr-iid-14
gitlab-mr-iid-12
gitlab-mr-iid-11
gitlab-mr-iid-10
gitlab-mr-iid-9
gitlab-mr-iid-8
gitlab-mr-iid-7
gitlab-mr-iid-6
gitlab-mr-iid-5
gitlab-mr-iid-4
gitlab-mr-iid-3
gitlab-mr-iid-2
gitlab-mr-iid-1
v0.5.3
v0.5.1
v0.5.0
v0.4.0
v0.3.0
v0.2.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma-elixir-libraries/linkify#25
No description provided.