Grouped reports improvements
There are 2 known issues with grouped reports
- Occurs when status was deleted, but we didn't have any data baked in inside report activity to show in admin-fe (we only have object tombstone, which stores no data). In that case we should send something like
deleted: true
inside status JSON. - Occurs when we
group_by
by activityap_id
, which is"http://localhost:4000/activities/56424119-9c5e-4b72-83cf-8777fbe64cd5"
for old format and{"id": ""http://localhost:4000/activities/56424119-9c5e-4b72-83cf-8777fbe64cd5", ...}
for the new one. Which is treated like different statuses, but it's the same one.
-
handle deleted statuses in the old format -
handle issue, when same status is being treated like different, when it was reported both in old and new format (fixed by pleroma!2003 (closed)) -
some report groups are duplicated for the same status (status: http://localhost:4000/activities/c0f7a427-fa56-4b48-a4e9-6368107eca86) (fixed by pleroma!2003 (closed))
"old" format is (data->'object'
):
[
"http://localhost:4000/users/shshsh",
"http://localhost:4000/activities/56424119-9c5e-4b72-83cf-8777fbe64cd5",
"http://localhost:4000/activities/c0f7a427-fa56-4b48-a4e9-6368107eca86",
"http://localhost:4000/activities/9639f491-8e64-4088-a46c-576b942f74af"
]
"new" format is (data->'object'
):
[
"http://localhost:4000/users/shshsh",
{
"id": "http://localhost:4000/activities/56424119-9c5e-4b72-83cf-8777fbe64cd5",
"type": "Note",
"actor": {
"id": "9mdHrbSOv1duwQvTUm",
"tags": ["force_nsfw"],
"local": true,
"roles": { "admin": false, "moderator": false },
"avatar": "http://localhost:4000/images/avi.png",
"nickname": "shshsh",
"deactivated": false,
"display_name": "shsh"
},
"content": "dasdsa",
"published": "2019-09-07T18:39:23.584555Z"
},
{
"id": "http://localhost:4000/activities/c0f7a427-fa56-4b48-a4e9-6368107eca86",
"type": "Note",
"actor": {
"id": "9mdHrbSOv1duwQvTUm",
"tags": ["force_nsfw"],
"local": true,
"roles": { "admin": false, "moderator": false },
"avatar": "http://localhost:4000/images/avi.png",
"nickname": "shshsh",
"deactivated": false,
"display_name": "shsh"
},
"content": "Studio",
"published": "2019-09-06T16:41:57.591585Z"
}
]
Edited by Maxim Filippov