Quoted posts do not inherit background color of highligted parent posts #1334

Open
opened 2024-08-12 17:55:37 +00:00 by phnt · 5 comments
Member

When a quote reply is highlighted (by clicking on the timestamp, by expanding its thread,...), the quoted post does not inherit the same highlight color.

obrazek

<!-- please use one of the templates if applicable, otherwise - type out here in free-form --> When a quote reply is highlighted (by clicking on the timestamp, by expanding its thread,...), the quoted post does not inherit the same highlight color. ![obrazek](/attachments/186757b6-8f87-4ee9-b15c-7ad8ce1f295e)
Owner

Yeah i'm not sure if it should be highlighted in this case, it's not selected per se

Yeah i'm not sure if it should be highlighted in this case, it's not selected per se
Author
Member

I see where you are coming from. My assumption was that this should have been styled that way, because that was the behavior before.

Maybe it would be better to style the hide/show header with the non-highlighted background since they are already in the same frame anyway. This way the quoted post would be more visibly separate from the reply like it is now. That would however be inconsistent with the "Quoted status unavailable" error message that also uses the same highlighted color when the reply post is selected.

I see where you are coming from. My assumption was that this should have been styled that way, because that was the behavior before. Maybe it would be better to style the hide/show header with the non-highlighted background since they are already in the same frame anyway. This way the quoted post would be more visibly separate from the reply like it is now. That would however be inconsistent with the "Quoted status unavailable" error message that also uses the same highlighted color when the reply post is selected.
Owner

because that was the behavior before

in a way, yes, but old behavior can also be somewhat misleading:
image{width=522 height=353}

Previously the quoted post would "inherit" (i.e. be transparent) highlights from post below, making it look like the post belongs to user who quoted it. It would look even stranger with multiple highlights stacked.

I think making the "quoated status unavailable" and/or expander have the status background would be better.

>because that was the behavior before in a way, yes, but old behavior can also be somewhat misleading: ![image](/attachments/6ddae5aa-95a0-4e22-9099-3c1f61181ab4){width=522 height=353} Previously the quoted post would "inherit" (i.e. be transparent) highlights from post below, making it look like the post belongs to user who quoted it. It would look even stranger with multiple highlights stacked. I think making the "quoated status unavailable" and/or expander have the status background would be better.
268 KiB
Owner

Looked deeply into it and I don't think there is a quick fix for it, so not in 2.7.x. I think most likely I will fix it when I implement User Highlight 2.0

Looked deeply into it and I don't think there is a quick fix for it, so not in 2.7.x. I think most likely I will fix it when I implement User Highlight 2.0
Author
Member

No need to rush, it's a nitpick. For the time being it can be fixed with custom CSS in browser (hardcode the quoted-status class background with the unfocused status color.) That doesn't seem to break anything else.

No need to rush, it's a nitpick. For the time being it can be fixed with custom CSS in browser (hardcode the `quoted-status` class background with the unfocused status color.) That doesn't seem to break anything else.
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe#1334
No description provided.