Improve localStorage #144

Closed
opened 2018-09-08 01:59:47 +00:00 by hj · 0 comments
Member

This is just an issue covering stuff i do and plan to do.

  • Remove 60s throttle on localstorage saving
  • Make it so that saving to localstorage only happens when there's something to save there
  • Separate user configuration from instance configuration
  • Remove or simplify whitelist of stuff saved to localstorage so that nobody forgets to add new path to the list
  • Add a feedback when changes are saved or if there's been an error.

This should fix:

  • login/logout problems
  • having to wait some time until settings are actually saved (and due to nature of that throttle it's not exactly predictable)
  • (see above but also about unread notifications)
  • huge mess in code with nearly every thing using setOption to store some stuff, be it user setting or instance name
  • feedback should clear up the "...did it save or i'm missing a 'Apply' button?" and "is it actually not saving or somebody forgot to add path to whitelist again?"
This is just an issue covering stuff i do and plan to do. * [x] Remove 60s throttle on localstorage saving * [x] Make it so that saving to localstorage only happens when there's something to save there * [x] Separate user configuration from instance configuration * [x] Remove or simplify whitelist of stuff saved to localstorage so that nobody forgets to add new path to the list * [x] Add a feedback when changes are saved or if there's been an error. This should fix: * login/logout problems * having to wait some time until settings are actually saved (and due to nature of that throttle it's not exactly predictable) * (see above but also about unread notifications) * huge mess in code with nearly every thing using `setOption` to store some stuff, be it user setting or instance name * feedback should clear up the "...did it save or i'm missing a 'Apply' button?" and "is it actually not saving or somebody forgot to add path to whitelist again?"
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe#144
No description provided.