pleroma/pleroma-fe
2
1
Fork 1
Code Issues 344 Pull requests 28 Projects Releases Packages Wiki Activity

Another one of those MR that fixes many many small-to-medium things #1597

Closed
hj wants to merge 0 commits from gitlab-mr-iid-324 into develop
pull from: gitlab-mr-iid-324
merge into: pleroma:develop
Conversation 1 Commits - Files changed -
hj commented 2018-08-27 20:29:45 +00:00
Owner
Copy link
  • Fixes #92 and maybe-fixes bugs where likes counter showing more likes than there is really.
  • Improves on #1581 : makes tab-switcher a reusable component, adds styles to make tabs look like tabs and not like buttons.
  • Fixes StillImage: maintain aspect ratio of <canvas> (no more stretching), fixed canvas rendering with 1,1 offset, made canvas render at image's original resoultion.
  • Fixes favorite button jumping places because retweet button being hidden for FO/DM posts. Now lock icon with alt-text explaining the reason why it's so is shown
  • Fixes #75
  • (Partially) fixes #122
  • Cleans up some styles in panels, decreased padding in panel's title to be more inline with content, moved unseen-counter to be after title to make it less jumpy.
  • Fixes #52
  • Fixes #72
  • Fixes #87
  • Adds optional ability to have logo in navbar to follow color scheme of the theme, so no more white-on-white logo.png.
    Uses CSS masks which are not available in some browsers (IE11, Edge) in those cases it falls back to displaying image (check is done via JS because @supports css media query itself isn't... supported everywhere). This requires image to be monochromatic and basically just uses alpha channel of it. Also works with SVGs. For instances that have colored logo (i.e. CRT) added config option for disabling this feature logoMask: false (default: true)
  • Added option to adjust space between logo and navbar, logoMargin, it's a CSS length-value with units. So that admins don't have to change image itself and can just crop image to save on traffic/load times (sweet jesus fuck, CRT's logo is HUGE (in dimensions)).
  • Changed section related to staticConfig and apiConfig - instead of using likes of apiConfig.stuff || staticConfig.stuff which will cause problems like apiConfig.stuff = false || staticConfig.stuff = true ==> true instead using Object.assign to combine both objects and use that instead.
* Fixes #92 and maybe-fixes bugs where likes counter showing more likes than there is really. * Improves on #1581 : makes tab-switcher a reusable component, adds styles to make tabs look like tabs and not like buttons. * Fixes `StillImage`: maintain aspect ratio of `<canvas>` (no more stretching), fixed canvas rendering with 1,1 offset, made canvas render at image's original resoultion. * Fixes favorite button jumping places because retweet button being hidden for FO/DM posts. Now lock icon with alt-text explaining the reason why it's so is shown * Fixes #75 * (Partially) fixes #122 * Cleans up some styles in panels, decreased padding in panel's title to be more inline with content, moved unseen-counter to be after title to make it less jumpy. * Fixes #52 * Fixes #72 * Fixes #87 * Adds optional ability to have logo in navbar to follow color scheme of the theme, so no more white-on-white `logo.png`. Uses CSS masks which are not available in some browsers ([IE11, Edge](https://caniuse.com/#feat=css-masks)) in those cases it falls back to displaying image (check is done via JS because `@supports` css media query itself isn't... *supported* everywhere). This requires image to be monochromatic and basically just uses alpha channel of it. Also works with SVGs. For instances that have colored logo (i.e. [CRT](http://cathoderay.tube)) added config option for disabling this feature `logoMask: false` (default: true) * Added option to adjust space between logo and navbar, `logoMargin`, it's a CSS length-value with units. So that admins don't have to change image itself and can just crop image to save on traffic/load times (sweet jesus fuck, CRT's logo is HUGE (in dimensions)). * Changed section related to `staticConfig` and `apiConfig` - instead of using likes of `apiConfig.stuff || staticConfig.stuff` which will cause problems like `apiConfig.stuff = false || staticConfig.stuff = true ==> true` instead using `Object.assign` to combine both objects and use that instead.
hakabahitoyo commented 2018-08-31 04:18:29 +00:00
Member
Copy link

I feel this MR had better to be divided into some small MRs.

I feel this MR had better to be divided into some small MRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!1597
No description provided.