Add emoji selector #2006

Closed
jaredr wants to merge 0 commits from gitlab-mr-iid-736 into develop
Member

Closes #101

Closes #101
Owner

unused?

unused?
Owner

????

????
Owner

really not liking the dynamic :ref= there, this feels like jQuery at this point

really not liking the dynamic `:ref=` there, this feels like jQuery at this point
Author
Member

Yes. I was hesitant which one to use. I will remove this one.

Yes. I was hesitant which one to use. I will remove this one.
Owner

should be sorted, but not here - where it's obtained (instance.js i believe) since order is all over the damn place.

should be sorted, but not here - where it's obtained (instance.js i believe) since order is all over the damn place.
Owner

I think custom emojis are much more often used in fedi and should have higher priority over unicode ones.

I think custom emojis are much more often used in fedi and should have higher priority over unicode ones.
Owner

i'd make it size of container with object-fit: contain for consistency, probably can remove wrapper, too

i'd make it size of container with `object-fit: contain` for consistency, probably can remove wrapper, too
Owner

try

<div @click.prevent.stop>

vue already has modifier to add stopPropagation()

try ```vue <div @click.prevent.stop> ``` vue already has modifier to add `stopPropagation()`
Owner

image

Conflicts with already existing picker

![image](/attachments/6209a254-b2c9-40c8-9613-41d9b4b2f623) Conflicts with already existing picker
Owner

I'm REALLY not liking that there's copypaste between post form and emoji input.

Also i EXPLICITLY ASKED you to refactor EmojiInput before you do Emoji picker, so please do that and then we can see about this MR.

I'm **REALLY** not liking that there's copypaste between post form and emoji input. Also i **EXPLICITLY ASKED** you to refactor EmojiInput before you do Emoji picker, so please do that and then we can see about this MR.

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2006
No description provided.