pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

Add Conversation/Thread Muting #2143

Closed
shpuld wants to merge 0 commits from gitlab-mr-iid-876 into develop
pull from: gitlab-mr-iid-876
merge into: pleroma:develop
Conversation 3 Commits - Files changed -
shpuld commented 2019-07-07 20:03:26 +00:00
Member
Copy link

Adds Mute/Unmute conversation options in status ellipsis menu

Adds Mute/Unmute conversation options in status ellipsis menu
hj commented 2019-07-15 21:54:12 +00:00
Member
Copy link
  1. Backend (at least my version) is increadibly wonky, doesn't always report posts as muted
  2. We update muted for only one status, but probably should go over entire conversation, but we need conversationId, don't remember if we still have that or it's KIA during MastoAPI wars
1. Backend (at least my version) is increadibly wonky, doesn't always report posts as muted 2. We update muted for only one status, but probably should go over entire conversation, but we need conversationId, don't remember if we still have that or it's KIA during MastoAPI wars
shpuld commented 2019-07-19 19:57:44 +00:00
Author
Member
Copy link

I noticed the BE issue as well, I told people about it on IRC but not sure if there's an issue. I don't think the 2. is something we should decide, it gives you more granular control if it doesn't nuke the entire conversation but just one branch, I think it's up to BE to decide how it works when user mutes one status.

I noticed the BE issue as well, I told people about it on IRC but not sure if there's an issue. I don't think the 2. is something we should decide, it gives you more granular control if it doesn't nuke the entire conversation but just one branch, I think it's up to BE to decide how it works when user mutes one status.
rinpatch commented 2019-07-20 06:27:27 +00:00
Member
Copy link

We update muted for only one status, but probably should go over entire conversation, but we need conversationId, don't remember if we still have that or it's KIA during MastoAPI wars

you do have pleroma.conversation_id https://docs-develop.pleroma.social/differences_in_mastoapi_responses.html#statuses

2. is something we should decide, it gives you more granular control if it doesn't nuke the entire conversation but just one branch, I think it's up to BE to decide how it works when user mutes one status.

The current implementation just mutes the entire conversation if one status is muted.

Backend (at least my version) is increadibly wonky, doesn't always report posts as muted

Not sure why it's happening, considering it's queried from the db every time, but we could fix it to be consistent when muting at least.

> We update muted for only one status, but probably should go over entire conversation, but we need conversationId, don't remember if we still have that or it's KIA during MastoAPI wars you do have `pleroma.conversation_id` https://docs-develop.pleroma.social/differences_in_mastoapi_responses.html#statuses > 2\. is something we should decide, it gives you more granular control if it doesn't nuke the entire conversation but just one branch, I think it's up to BE to decide how it works when user mutes one status. The current implementation just mutes the entire conversation if one status is muted. > Backend (at least my version) is increadibly wonky, doesn't always report posts as muted Not sure why it's happening, considering it's queried from the db every time, but we could fix it to be consistent when muting at least.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!2143
No description provided.