pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

OAuth 'push' and 'admin' scopes support #2291

Closed
i1t wants to merge 0 commits from gitlab-mr-iid-1024 into develop
pull from: gitlab-mr-iid-1024
merge into: pleroma:develop
Conversation 3 Commits - Files changed -
i1t commented 2019-12-08 10:55:18 +00:00
Member
Copy link

Required for "Login with PleromaFE" feature of AdminFE: pleroma/admin-fe#301

Also, per pleroma/admin-fe#301, admin scope would be required for moderation features of PleromaFE.

BE feature: pleroma/pleroma#5403

Required for "Login with PleromaFE" feature of AdminFE: https://git.pleroma.social/pleroma/admin-fe/pulls/301 Also, per https://git.pleroma.social/pleroma/admin-fe/pulls/301#note_47505, `admin` scope would be required for moderation features of PleromaFE. BE feature: https://git.pleroma.social/pleroma/pleroma/pulls/5403
i1t commented 2019-12-10 20:41:57 +00:00
Author
Member
Copy link

@rinpatch BE MR was merged, please merge this one.

@rinpatch BE MR was merged, please merge this one.
hj commented 2019-12-10 20:51:42 +00:00
Owner
Copy link

will it work on older BEs tho?

will it work on older BEs tho?
i1t commented 2019-12-11 08:51:05 +00:00
Author
Member
Copy link

@hj it surely would work with older BEs, even if those BEs aren't aware of admin / push scopes. Client apps may request any number of arbitrarily named scopes, e.g. "scope1", "scope2", "scope3", and it won't do anything (neither good or bad) until BE starts making any difference basing on any of these actions absence / presence in any of its controller actions.

@hj it surely would work with older BEs, even if those BEs aren't aware of `admin` / `push` scopes. Client apps may request any number of arbitrarily named scopes, e.g. "scope1", "scope2", "scope3", and it won't do anything (neither good or bad) until BE starts making any difference basing on any of these actions absence / presence in any of its controller actions.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2291
No description provided.