pleroma/pleroma-fe

Fork 0

Settings is split between two different places #259

New issue

Closed

opened 2019-01-05 05:20:29 +00:00 by normandy · 10 comments

normandy commented

2019-01-05 05:20:29 +00:00

Member

Currently there's two different settings panels: one for account settings (if logged in), and another for theming/filters (no need to login).

Both are represented by a cogwheel, differing only in where it's located. Having used Pleroma on and off for about a year now, this still confuses me from time to time.

There should be something that makes this obvious or probably these two separate settings panels should be combined somehow with a single link to it.

Currently there's two different settings panels: one for account settings (if logged in), and another for theming/filters (no need to login). Both are represented by a cogwheel, differing only in where it's located. Having used Pleroma on and off for about a year now, this still confuses me from time to time. There should be something that makes this obvious or probably these two separate settings panels should be combined somehow with a single link to it.

hj commented

2019-01-05 06:38:58 +00:00

Owner

probably at the very least should change cog in user card to a pencil and change "User settings" to "User account"

shpuld commented

2019-01-06 07:00:41 +00:00

Owner

I'd prefer having everything in one place if it can be made in a way that makes sense and isn't overwhelming. The current separation is a bit of a qvitterism, where you had editing the user profile always handy in your profile page (and it didn't open a new page, it embedded the edit options nicely in the profile itself), while actual settings were somewhere completely different. If we keep things separated I think profile should only have soft settings like changing name/bio/avatar/bg etc, while anything that alters the behavior of the application should be in real settings. Or at least that's my thoughts on it.

+1 for pen icon on profile w

shpuld commented

2019-01-06 07:07:05 +00:00

Owner

Err, now when thinking about what I wrote (had 2 different lines of thought there), the way qvitter did it was good, as in keeping only the soft settings on the profile, our mistake hasn't been the separation but adding a lot of other things into the user profile.

hj commented

2019-01-06 07:24:28 +00:00

Owner

Another thing about splitting is the perspective of finally having sync between localstorage and BE. It would be cool to have same theme and user-highlights across all the devices, but at the same time NOT having the option to NOT to sync settings would be kind of a regression - if you set FE to hide attachments while at work machine it would also affect home machine and cause bigger annoyance, at least to me. So if we make some sort of special kind of thing like "do not sync on this machine" checkbox or something it would confuse people why profile settings are still synced.

The separation does make sense as long as it's not a mish-mash. Right now you could call profile "account settings", so all the account-related stuff is in there - importing exporting followers, password change, profile settings, etc. The only thing that doesn't make sense being there is "Strip rich text formatting from all posts", especially since i get the feeling BE could be sending both stripped and non-stripped data and FE could just switch between them by itself. The only reason it's there is because it's a BE-related setting, maybe we could change it up, idk. Another thing about splitting is the perspective of finally having sync between localstorage and BE. It would be cool to have same theme and user-highlights across all the devices, but at the same time NOT having the option to NOT to sync settings would be kind of a regression - if you set FE to hide attachments while at work machine it would also affect home machine and cause bigger annoyance, at least to me. So if we make some sort of special kind of thing like "do not sync on this machine" checkbox or something it would confuse people why profile settings are still synced.

shpuld commented

2019-01-06 08:41:05 +00:00

Owner

I guess it's a matter of perspective, I'd prefer to have an account tab under settings instead of having 2 different settings, I mean despite being stored differently (something that user doesn't know or care about), it's still settings.

hj commented

2019-01-06 08:46:15 +00:00

Owner

probably good idea to have an account tab if we merge all of current tabs into one or something and put a notice there that these settings are always synced no matter what (when we have that)

shpuld commented

2019-01-06 08:51:27 +00:00

Owner

yeah (apart from maybe the name/bio/etc which could probably implemented in a much cleaner way on the profile page itself without a separate settings view, like double clicking on your name to edit it, etc). I do agree we're in a bit of a soup when it comes to some settings being per machine and others being per user, I'd say the regression of having theme be per user in BE is worth it, because it also allows us to make the cool thing of showing other peoples themes when you visit their profiles and stuff like that.

hj commented

2019-01-06 09:19:37 +00:00

Owner

except theme showcase should be a separate and optional thing :)

shpuld commented

2019-01-06 09:35:31 +00:00

Owner

why would it have to be? I mean do you go open other peoples profiles often (especially when opening lain's profile kills your browser lol)

hj commented

2019-01-06 10:33:48 +00:00

Owner

i have a feeling some people might want to use one theme and showcase another, simply because one fits their style and other looks easier on eyes, idk