Virtual scrolling

succfemboi commented

2019-01-26 13:43:00 +00:00

Member

Normally posts which aren't being displayed anymore are still being rendered.

Having a virtual scroller would make the site appear smoother by only rendering posts which are being scrolled though and removing elements from the DOM which currently aren't displayed.

There already is a module vue called vue-virtual-scroller and here is a demo of it in action https://akryum.github.io/vue-virtual-scroller/#/dynamic

Maybe it could prevent that I sometimes see the background image instead of the timeline if I scroll the timeline on my phone very fast

Normally posts which aren't being displayed anymore are still being rendered. Having a virtual scroller would make the site appear smoother by only rendering posts which are being scrolled though and removing elements from the DOM which currently aren't displayed. There already is a module vue called [vue-virtual-scroller](https://github.com/Akryum/vue-virtual-scroller) and here is a demo of it in action https://akryum.github.io/vue-virtual-scroller/#/dynamic Maybe it could prevent that I sometimes see the background image instead of the timeline if I scroll the timeline on my phone very fast

shpuld commented

2019-01-26 21:15:45 +00:00

Member

I've looked into it before, haven't tried implementing it. might be more reasonable if the attachment/media-modal is merged in and statuses have more fixed sizes. previously that has been a potential problem

succfemboi commented

2019-01-27 13:01:53 +00:00

Author

Member

Actually, the post height can be influenced by the text length anyway but one could just use dynamic scroller for now

shpuld commented

2019-01-28 04:34:01 +00:00

Member

Yeah but with flexing attachments it could change when the images load, I doubt the dynamic option would deal with changing elements well.

succfemboi commented

2019-01-28 14:10:39 +00:00

Author

Member

Probably the elements would adjust to it anyway, considering that the dynamic scroller can emit a resize-event if I read it correctly

Probably the elements would adjust to it anyway, considering that the dynamic scroller can emit a `resize`-event if I read it correctly

jasper commented

2019-02-05 10:16:16 +00:00

Member

The way I see it, it's hard to work properly by using vue-virtual-scroller.
I think it should be implemented newly refer to the module.
@succfemboi I can work on it if you agree with me.

The way I see it, it's hard to work properly by using vue-virtual-scroller. I think it should be implemented newly refer to the module. @succfemboi I can work on it if you agree with me.

succfemboi commented

2019-02-06 06:27:59 +00:00

Author

Member

@jasper I think I did try to implent it by myself with the virtual is roller module, but I didn't know how to actually use it in the timeline. JavaScript is still relatively new to me.

I guess it would be better to design a module after a project and not the other way around

@jasper I think I did try to implent it by myself with the virtual is roller module, but I didn't know how to actually use it in the timeline. JavaScript is still relatively new to me. I guess it would be better to design a module after a project and not the other way around

succfemboi commented

2019-02-09 17:58:56 +00:00

Author

Member

If I understand it right, it does not even need an external module for virtual scrolling to happen?

jasper commented

2019-02-11 06:02:14 +00:00

Member

@succfemboi yeah, right. I think it doesn't need, the module you mentioned is not suitable for pleroma-fe.

succfemboi commented

2019-02-11 06:22:47 +00:00

Author

Member

Would you still work on it?

jasper commented

2019-02-11 07:17:29 +00:00

Member

yes, but I need to do some more test to check if it can work properly.

succfemboi commented

2019-03-05 18:27:34 +00:00

Author

Member

Anything still needed to be tested? Maybe I could help

jasper commented

2019-03-06 10:14:47 +00:00

Member

oh, I didn't focus on this issue for a while. I'll try to finalize it as quick as possible.

succfemboi commented

2019-03-17 17:50:55 +00:00

Author

Member

Will this feature affect how i18n gets structured?

jasper commented

2019-03-18 06:24:42 +00:00

Member

It will not affect i18n at all.

succfemboi commented

2019-03-21 18:31:56 +00:00

Author

Member

Do you have a branch which has virtual scrolling support on it?

I'm trying to implement code splitting which might change how modules get loaded

Do you have a branch which has virtual scrolling support on it? I'm trying to implement [code splitting](https://git.pleroma.social/pleroma/pleroma-fe/pulls/1934) which might change how modules get loaded

succfemboi commented

2019-03-30 12:50:24 +00:00

Author

Member

Is there any reference of implementing this feature?