Quick View Menu for timeline and conversations, filter for conversations #2845

Closed
hj wants to merge 0 commits from gitlab-mr-iid-1578 into develop
Owner

Also refactored stuff just a tiny bit. Closes #1179

Timeline

imageimage

Conversation

imageimage

Also refactored stuff just a tiny bit. Closes #1179 # Timeline ![image](/attachments/cb51a254-c616-473c-a5a7-db5ee12da01d)![image](/attachments/48276f0d-a7b4-43be-b80d-ed379708cb1a) # Conversation ![image](/attachments/e997b351-6bc3-42cc-a760-b827959a1398)![image](/attachments/5fec184f-a856-4517-8ba2-2269795758e1)
Owner

"Show user avatars next to mentions" cannot be deselected

"Show user avatars next to mentions" cannot be deselected
Owner

Switching between Linear view and Tree view should not make the update button become "Reload," as the settings counterpart won't.

Switching between Linear view and Tree view should not make the update button become "Reload," as the settings counterpart won't.
Owner

misaligned bars icon looks pretty weird

misaligned bars icon looks pretty weird
Author
Owner

same icon as in navigation, can change to just "burger" icon

same icon as in navigation, can change to just "burger" icon
Author
Owner

wonder why it does that...

wonder why it does that...
Author
Owner

nice catch!

nice catch!
Owner

oh, ok

oh, ok
Owner

not sure, is it reusing the single-selection component from the filtering menu? cause that makes it change to a reload which makes sense there but not here

not sure, is it reusing the single-selection component from the filtering menu? cause that makes it change to a reload which makes sense there but not here
Author
Owner

it's copypasted from that component, so probably there's a leftofer that does that. There's also an issue that tree/list options aren't shown to anon viewers that i need fix.

it's copypasted from that component, so probably there's a leftofer that does that. There's also an issue that tree/list options aren't shown to anon viewers that i need fix.
Owner

this line

this line
Author
Owner
```suggestion:-0+0 ```
Owner

ok except lint warnings

ok except lint warnings

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2845
No description provided.