pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Fix few markup inconsistencies #3275

Closed
pleromian wants to merge 5 commits from gitlab-mr-iid-2008 into develop
pull from: gitlab-mr-iid-2008
merge into: pleroma:develop
Conversation 10 Commits 5 Files changed 14 +355 -314
pleromian commented 2025-01-25 15:56:09 +00:00
Member
Copy link

Fix some more markup inconsistencies and make ToS a first-class citizen; see screenshots (kazv.moe proxied)

/about
Screenshot_2025-01-25_at_16.55.13

/registration
Screenshot_2025-01-25_at_16.55.47

adding sticky allows to have active panel be always focused after scrolling down (about page):
Screenshot_2025-01-28_at_17.57.27

padding for Staff panel:

Screenshot_2025-02-04_at_19.52.42

Drafts:

Screenshot_2025-02-04_at_19.54.09

Fix some more markup inconsistencies and make ToS a first-class citizen; see screenshots (kazv.moe proxied) `/about` ![Screenshot_2025-01-25_at_16.55.13](/attachments/4a28355d-3c46-4e62-bc48-898000d25ed4) `/registration` ![Screenshot_2025-01-25_at_16.55.47](/attachments/bc09f844-482b-4afc-a201-fc57997e9806) adding `sticky` allows to have active panel be always focused after scrolling down (about page): ![Screenshot_2025-01-28_at_17.57.27](/attachments/d8dffc2a-e23a-4a75-922e-b7da8c80182a) padding for Staff panel: ![Screenshot_2025-02-04_at_19.52.42](/attachments/31e3c39d-8bf6-4081-846a-7f9ec50824f1) Drafts: ![Screenshot_2025-02-04_at_19.54.09](/attachments/bcd5e0e0-0982-4077-b247-4c322e2c47bb)
Screenshot_2025-01-25_at_16.55.13.png
213 KiB
Screenshot_2025-01-25_at_16.55.47.png
213 KiB
Screenshot_2025-01-28_at_17.57.27.png
97 KiB
Screenshot_2025-02-04_at_19.52.42.png
7.6 KiB
Screenshot_2025-02-04_at_19.54.09.png
11 KiB
pleromian commented 2025-01-25 15:57:34 +00:00
Author
Member
Copy link

Optionally registration page can feature "By registering, you're agreeing with Terms of Service" somewhere, but I think it's already assumed if they go first.

Optionally registration page can feature "By registering, you're agreeing with Terms of Service" somewhere, but I think it's already assumed if they go first.
pleromian commented 2025-01-25 16:00:07 +00:00
Author
Member
Copy link

Also GitLab's diff viewer doesn't like registration page, but essentially ToS were moved to a separated if-guarded component and page class was added, no changes to the form at all.

Also GitLab's diff viewer doesn't like registration page, but essentially ToS were moved to a separated if-guarded component and page class was added, no changes to the form at all.
tusooa commented 2025-01-25 16:01:05 +00:00
Owner
Copy link

i think this has been discussed in #2511

i think this has been discussed in https://git.pleroma.social/pleroma/pleroma-fe/pulls/2511
pleromian commented 2025-01-25 16:04:27 +00:00
Author
Member
Copy link

@tusooa fair point, but I believe for the ToS panel feature mentioned there one would be better off with instance-specific panel? Otherwise, separation/embedding of ToS panel can be a configuration setting

@tusooa fair point, but I believe for the ToS panel feature mentioned there one would be better off with instance-specific panel? Otherwise, separation/embedding of ToS panel can be a configuration setting
pleromian commented 2025-01-25 16:09:59 +00:00
Author
Member
Copy link

also I'd swap Staff and ToS places on the About page, it would look more consistent in my opinion (terms first, then everything else)

also I'd swap Staff and ToS places on the About page, it would look more consistent in my opinion (terms first, then everything else)
hj commented 2025-01-28 14:20:17 +00:00
Owner
Copy link

I think ToS panel should be left as-is. People might not use "terms of service" uh, term, and replace it with "Instance rules" for instance.

I think ToS panel should be left as-is. People might not use "terms of service" uh, term, and replace it with "Instance rules" for instance.
pleromian commented 2025-01-28 16:54:25 +00:00
Author
Member
Copy link

@hj what's about making it configurable? i.e. by default it's embedded, but users can make it separate if they feel like.

@hj what's about making it configurable? i.e. by default it's embedded, but users can make it separate if they feel like.
hj commented 2025-01-29 12:48:21 +00:00
Owner
Copy link

Yes, it can be instance option

Yes, it can be instance option
pleromian commented 2025-02-04 18:55:23 +00:00
Author
Member
Copy link

@hj should be ready now

@hj should be ready now
pleromian commented 2025-02-06 10:04:17 +00:00
Author
Member
Copy link

@tusooa what do you think?

@tusooa what do you think?

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!3275
No description provided.