Fix sticking scroll logic #3599

Merged

hj merged 10 commits from fix-scroll-bugs into develop 2026-11-03 15:30:53 +00:00

Conversation 2 Commits 10 Files changed 3 +89 -51

hj commented 2026-11-02 17:38:26 +00:00

Member

Copy link

Fixes chats glitching out when scrolled to bottom
Fixes chats not sticking to bottom on new posts
Fixes timeline not sticking to top on new posts
Fix scroll on thread expansion/collapse in userprofile

Fixes chats glitching out when scrolled to bottom Fixes chats not sticking to bottom on new posts Fixes timeline not sticking to top on new posts Fix scroll on thread expansion/collapse in userprofile

hj added 2 commits 2026-11-02 17:38:26 +00:00

fix sticking logic d7b9eaa00c

dedupe e5bb22f159

hj added 1 commit 2026-11-02 19:23:08 +00:00

user profile scrolling fixes 6d645ad0e6

hj added 1 commit 2026-11-02 19:23:35 +00:00

lint 76cfe69ccb

hj added 1 commit 2026-11-03 13:30:00 +00:00

even better shift/stick logic f33c724e20

hj changed title from WIP: Fix sticking scroll logic to Fix sticking scroll logic 2026-11-03 13:31:34 +00:00

hj added 1 commit 2026-11-03 13:32:04 +00:00

"changelog" 3cbb6efa38

hj added 1 commit 2026-11-03 13:32:21 +00:00

lint 0a6569d57e

hj added 1 commit 2026-11-03 13:35:46 +00:00

lint c33dd855fd

hj added 2 commits 2026-11-03 15:12:26 +00:00

proper accounting for panel header + clamp height to scroller vHeight bcc763517a

lint 928c6586a5

hj commented 2026-11-03 15:19:18 +00:00

Author

Member

Copy link

/oc review

/oc review

👀 1

opencode-fix-bot approved these changes 2026-11-03 15:29:20 +00:00

opencode-fix-bot left a comment

Copy link

opencode-agent:job=167:generation=1

Verdict

No findings. This PR is approved — merge-readiness 5/5.

Scope reviewed

Base-to-head diff (dc1f287 → 928c658), 3 files, +89/−51:

• src/composables/useVirtualScrolling.js — getShift rewrite with anchor-miss compensation
• src/components/conversation/conversation.js — scrollOffset rework to measured DOM offsets, height clamping
• changelog.d/scrollfixes.skip — empty skip file

What I verified

• Chat stick-to-bottom (invertDirection, sticking): anchor-miss path now scrolls by the exact added-bottom height. The old code scrolled by the full body height here, which matches the reported glitching.
• Timeline stick-to-top (non-inverted, sticking): anchor-miss path now returns 0 via the isSticking && boundary === 'top' guard, so new posts no longer push a top-anchored view down.
• Scrolled-away cases still compensate: non-sticking anchor-miss returns the added height at the correct end (beItem → bNearestItem span), equivalent to the old first/last-item fallback.
• No crash paths: getShift's a[getExtreme(a)] / b[getExtreme(b)] indexing is only reachable when both lists are non-empty (explosion/implosion return earlier), and b[-1]/b[-2] misses safely yield undefined → return 0.
• -embedded check is real: timeline.js adds the -embedded root class for embedded timelines, so className.includes('-embedded') matches as intended.
• No new compat burden: findLastIndex is the same ES2023 generation as the findLast it replaces.
• Minor leftovers, intentionally not raised: the removed top prop is still passed by timeline.vue (falls through as a harmless HTML attribute) and expandOffset = 0 is dead — both nits, no behavior impact.

Validation run

• Full unit suite at the claimed head: 49 files, 514 passed, 2 skipped, 0 failed (browser-mode vitest; needed build/update-emoji.js + Playwright deps first).
• biome check on both changed source files: clean.
• Worktree left byte-for-byte at the claimed head; no commits, pushes, or branches created.

opencode-agent:job=167:generation=1 ### Verdict No findings. This PR is approved — merge-readiness **5/5**. ### Scope reviewed Base-to-head diff (`dc1f287` → `928c658`), 3 files, +89/−51: - `src/composables/useVirtualScrolling.js` — `getShift` rewrite with anchor-miss compensation - `src/components/conversation/conversation.js` — `scrollOffset` rework to measured DOM offsets, height clamping - `changelog.d/scrollfixes.skip` — empty skip file ### What I verified - **Chat stick-to-bottom** (`invertDirection`, sticking): anchor-miss path now scrolls by the exact added-bottom height. The old code scrolled by the full body height here, which matches the reported glitching. - **Timeline stick-to-top** (non-inverted, sticking): anchor-miss path now returns `0` via the `isSticking && boundary === 'top'` guard, so new posts no longer push a top-anchored view down. - **Scrolled-away cases still compensate**: non-sticking anchor-miss returns the added height at the correct end (`beItem` → `bNearestItem` span), equivalent to the old first/last-item fallback. - **No crash paths**: `getShift`'s `a[getExtreme(a)]` / `b[getExtreme(b)]` indexing is only reachable when both lists are non-empty (explosion/implosion return earlier), and `b[-1]`/`b[-2]` misses safely yield `undefined` → `return 0`. - **`-embedded` check is real**: `timeline.js` adds the `-embedded` root class for embedded timelines, so `className.includes('-embedded')` matches as intended. - **No new compat burden**: `findLastIndex` is the same ES2023 generation as the `findLast` it replaces. - **Minor leftovers, intentionally not raised**: the removed `top` prop is still passed by `timeline.vue` (falls through as a harmless HTML attribute) and `expandOffset = 0` is dead — both nits, no behavior impact. ### Validation run - Full unit suite at the claimed head: **49 files, 514 passed, 2 skipped, 0 failed** (browser-mode vitest; needed `build/update-emoji.js` + Playwright deps first). - `biome check` on both changed source files: clean. - Worktree left byte-for-byte at the claimed head; no commits, pushes, or branches created.

hj merged commit 94420874ef into develop 2026-11-03 15:30:53 +00:00

hj deleted branch fix-scroll-bugs 2026-11-03 15:30:53 +00:00

hj referenced this pull request from a commit 2026-11-03 15:30:53 +00:00

Merge pull request 'Fix sticking scroll logic' (#3599) from fix-scroll-bugs into develop

Sign in to join this conversation.

Reviewers

No reviewers

opencode-fix-bot

Labels

Clear labels   

BE Request

  

Backlog

  

Better behavior

  

Blocked by deps

  

Bug

  

Code Review

  

Discussion

  

Doing

  

Feature Request / Enhancement

  

In the shining bright future maybe

  

It's complicated

  

MS Edge

  

Mememoon (or other niche browsers)

  

Missing API

  

Missing feature

  

Missing l10n/i18n

  

NL1

Instance Admin Dashboard

  

NL2

Improved Mobile Experience

  

NL4

Improved instance customization and QoL options

  

Need to verify on develop

  

RELEASE BLOCKER

  

Reassign or Close

  

Refactor

  

Regression

  

Safari

  

To Do

  

User story

  

Waiting on godot

  

accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  

better documentation

  

chore

  

confirmed

  

easy ticket

  

incident

Denotes a disruption to IT services and the associated issues require immediate attention

  

l10n update

  

mastoapi

  

mobile

  

needs design

  

needs-info

  

needs-review

  

stupid

No labels

BE Request

Backlog

Better behavior

Blocked by deps

Bug

Code Review

Discussion

Doing

Feature Request / Enhancement

In the shining bright future maybe

It's complicated

MS Edge

Mememoon (or other niche browsers)

Missing API

Missing feature

Missing l10n/i18n

NL1

NL2

NL4

Need to verify on develop

RELEASE BLOCKER

Reassign or Close

Refactor

Regression

Safari

To Do

User story

Waiting on godot

accessibility

better documentation

chore

confirmed

easy ticket

incident

l10n update

mastoapi

mobile

needs design

needs-info

needs-review

stupid

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

pleroma/pleroma-fe!3599

No description provided.