Several issues related to timeline. #385

Closed
opened 2019-02-21 15:43:22 +00:00 by jasper · 1 comment
Member

While I've been working on #330, I've found several issues needed to fix.

  1. Each timeline (friend, public..) have it's own timeline fetcher(by timer) when create, but it also fetches statuses directly sometimes( by using 'queueflush', 'fetcholderstatus', 'fetchAndUpdate'). Fetching is repeated 2 or more times, and it makes troubles like that some statuses are in 'show new' even though they are already in visible timeline.

  2. If there is no statuses, fetched statuses must be visible. If there is no displayed status after block or delete, we can see there is no status but "show new" have some statuses fetched.

  3. we use "count" arg to set count of statuses to be fetched in FE. but in BE, it uses "limit".

  4. we have to stop fetcher completely. I mean, even though timer have been stopped, request already sent is still working.

Additionally, there is weird logic in some functions. I think we need to change or remove some of them.
Please let me know if there is anything I'm confusing.

While I've been working on #330, I've found several issues needed to fix. 1. Each timeline (friend, public..) have it's own timeline fetcher(by timer) when create, but it also fetches statuses directly sometimes( by using 'queueflush', 'fetcholderstatus', 'fetchAndUpdate'). Fetching is repeated 2 or more times, and it makes troubles like that some statuses are in 'show new' even though they are already in visible timeline. 2. If there is no statuses, fetched statuses must be visible. If there is no displayed status after block or delete, we can see there is no status but "show new" have some statuses fetched. 3. we use "count" arg to set count of statuses to be fetched in FE. but in BE, it uses "limit". 4. we have to stop fetcher completely. I mean, even though timer have been stopped, request already sent is still working. Additionally, there is weird logic in some functions. I think we need to change or remove some of them. Please let me know if there is anything I'm confusing.
Owner

Basically the entire timeline logic code is rotten and needs a rewrite in a way that can properly be unit tested. it's a nightmare right now

Basically the entire timeline logic code is rotten and needs a rewrite in a way that can properly be unit tested. it's a nightmare right now
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe#385
No description provided.