@ user completion is missing users or not completing #562

Closed
opened 2019-05-30 12:05:11 +00:00 by dashie · 6 comments
Member

When trying to @ someone, the completion thingy is always missing some, even the one I try to complete.

Trying to @famine in pleromafe result in no completion:

image

Doing "@famine@" to trigger the popup returns totally unrelated results:

image

But works in mastofe:

image

I don't see a js network query run in pleromafe when @ ing, so I guess the fe does use some builtin list of users on page load.

It feels like the completion only complete users who interacted with you recently.

When trying to @ someone, the completion thingy is always missing some, even the one I try to complete. Trying to @famine in pleromafe result in no completion: ![image](/attachments/25402dc3-8b8d-4295-91b0-cf5beef80ccf) Doing "@famine@" to trigger the popup returns totally unrelated results: ![image](/attachments/106627b9-f937-4b33-92f8-dfa6f6cfea0a) But works in mastofe: ![image](/attachments/d3784a13-cbf8-4d71-9510-d1d31b30a6c6) I don't see a js network query run in pleromafe when @ ing, so I guess the fe does use some builtin list of users on page load. It feels like the completion only complete users who interacted with you recently.
Member

@dashie it basically suggests you any matching users FE knows about, and it keeps track of all users it sees - i.e. all posts contain a user - author of the post. I think it also tries to fetch your own friends but it's probably broken.

But yeah we need to add support for user-search there

@dashie it basically suggests you any matching users FE knows about, and it keeps track of all users it sees - i.e. all posts contain a user - author of the post. I think it also tries to fetch your own friends but it's probably broken. But yeah we need to add support for user-search there
Member

When you search for a user with the normal search bar, it also adds them to the list of known users. I added searchUsers to the @ mark search for when a user is not found.

When you search for a user with the normal search bar, it also adds them to the list of known users. I added searchUsers to the @ mark search for when a user is not found.
Member

Cleared all discussions. Ready to be merged? @hj

Cleared all discussions. Ready to be merged? @hj
Member

just so you know @feld does not decide what gets merged and when

just so you know @feld does not decide what gets merged and when
Member

@hj Ah, Understood!

@hj Ah, Understood!
Member

MR merged, closing issue.

MR merged, closing issue.
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe#562
No description provided.