Notifications panel not reloaded upon login #563

Closed
opened 2019-05-31 03:21:43 +00:00 by feld · 4 comments
Owner

Logout as one user and login as another. Previous user's notifications are still in the notification panel.

Logout as one user and login as another. Previous user's notifications are still in the notification panel.
Member

Tested on Mac. Firefox Quantum, Safari 12.0.2, and Chrome 74.0.3729.169. Not seeing it replicated.

Tested on Mac. Firefox Quantum, Safari 12.0.2, and Chrome 74.0.3729.169. Not seeing it replicated.
Member
https://cl.ly/8968803af66d
Member

Tested this on local and a production instance. On the production instance a refresh is needed to update the notification panel. In some cases waiting between login and logout, while doing other activity also causes the correct behavior. I think it is a timing issue with prod being further away causing API timings issues on logout. i.e. notifications are not set in the DOM before the sign in occurs again. While on local there is no distance so everything updates correctly.

Easy fix: Refresh the page after logout.
Complex fix: Find the timing issue and make a promise to ensure order of execution. Make sure Vue updates the DOM regardless of timing.

Tested this on local and a production instance. On the production instance a refresh is needed to update the notification panel. In some cases waiting between login and logout, while doing other activity also causes the correct behavior. I think it is a timing issue with prod being further away causing API timings issues on logout. i.e. notifications are not set in the DOM before the sign in occurs again. While on local there is no distance so everything updates correctly. Easy fix: Refresh the page after logout. Complex fix: Find the timing issue and make a promise to ensure order of execution. Make sure Vue updates the DOM regardless of timing.

Tested it just now, has been fixed.

Tested it just now, has been fixed.
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe#563
No description provided.