Sidebar: Text input fields go too far

lambadalambda commented

2020-08-13 16:18:02 +00:00

Owner

Bisect says:

65b6e23c00 is the first bad commit

![Screenshot_2020-08-13__11__lain_com](/attachments/1865104b-8807-4211-8491-34aec49d5e68) Bisect says: 65b6e23c00f09f3627e29987302cd16c9e069da2 is the first bad commit

Screenshot_2020-08-13__11__lain_com.png

263 KiB

lambadalambda commented

2020-08-13 16:18:26 +00:00

Author

Owner

There actually is one 'bad' commit before this but this one is the first bad one that compiles

hj commented

2020-08-13 17:29:43 +00:00

Member

Browser?

hj commented

2020-08-13 18:27:21 +00:00

Member

can't reproduce neither in chrome nor firefox

shpuld commented

2020-08-14 05:47:00 +00:00

Member

I wasn't able to reproduce it either

lambadalambda commented

2020-08-14 08:54:38 +00:00

Author

Owner

It's firefox 79 on ubuntu. The only unusual thing about my setup is that i have layout.css.devPixelsPerPx to 1.5, but the same thing happens when i set it to default.

lambadalambda commented

2020-08-14 11:21:04 +00:00

Author

Owner

Also getting this.

Also getting this.![Screenshot_2020-08-14__3__lain_com](/attachments/7bc434fa-9df1-47f0-86b0-f281697cd8ad)

Screenshot_2020-08-14__3__lain_com.png

72 KiB

hj commented

2020-08-14 13:32:15 +00:00

Member

this one is known, i'll fix it soon

hj commented

2020-08-14 13:40:21 +00:00

Member

Doesn't reproduce in Firefox 81 either. It's either customization on instance or some addon messing things up

lambadalambda commented

2020-08-14 14:23:24 +00:00

Author

Owner

I thought it was an add on, too, but it does the same in privaet mode without add ons and I don't have any FE modifications on lain.com... Really strange.

hj commented

2020-08-14 15:43:49 +00:00

Member

Can we somehow do a videocall with you @lambadalambda so that you can present your screen and we figure out in devtools what causes that?

Does it behave the same in other browsers?

Can we somehow do a videocall with you @lambadalambda so that you can present your screen and we figure out in devtools what causes that? Does it behave the same in other browsers?

lambadalambda commented

2020-08-14 15:50:49 +00:00

Author

Owner

It only happens in FF and only after the CSS refactor. Videocall sounds good, I'll ping you on IRC

hj commented

2020-08-17 22:00:10 +00:00

Member

fixed in #2478

lambadalambda commented

2020-08-18 12:10:15 +00:00

Author

Owner

Found the issue. I have the default font for sans-serif set to Noto Sans CJK JP. If I change that back to the default (Deja Vu Sans), the issue goes away.

Found the issue. I have the default font for sans-serif set to Noto Sans CJK JP. If I change that back to the default (Deja Vu Sans), the issue goes away.![Screenshot_from_2020-08-18_14-09-01](/attachments/ea7bcd85-2675-45c4-ac17-80fe80f8a095)

Screenshot_from_2020-08-18_14-09-01.png

40 KiB

hj commented

2020-08-18 12:15:57 +00:00

Member

thanks, can reproduce now.

hj commented

2020-08-18 12:37:26 +00:00

Member

Figured it out. <textarea> by default has attribute cols="20" which defines it default/auto size, so it turns out it become bigger than container when used with certain fonts. No idea how exactly it calculates the size of it, but given that dividing textarea's effective width by cols gives somewhere around 15px while font-size is 14px, it seems that it might be using some japanese character as a base, so it's probably font-dependent.

will fix it in #2478 tonight

Figured it out. `<textarea>` by default has attribute `cols="20"` which defines it default/`auto` size, so it turns out it become bigger than container when used with certain fonts. No idea how exactly it calculates the size of it, but given that dividing textarea's effective width by `cols` gives somewhere around 15px while font-size is 14px, it seems that it might be using some japanese character as a base, so it's probably font-dependent. will fix it in #2478 tonight

hj commented

2020-08-19 10:21:15 +00:00

Member

fixed with #2478

lambadalambda commented

2020-09-18 12:09:12 +00:00

Author

Owner

still happens for me, current develop

![Screenshot_2020-09-18_Teilhard_de_Chardin___lain_lain_com_](/attachments/986c1a2d-d88f-4d3f-a23d-6f4454e1f184) still happens for me, current develop

Screenshot_2020-09-18_Teilhard_de_Chardin___lain_lain_com_.png

222 KiB

lambadalambda commented

2020-09-18 12:27:52 +00:00

Author

Owner

![Screenshot_from_2020-09-18_14-27-08](/attachments/adc13c16-bcf9-482b-ab1d-04f5a51ab1a7)

Screenshot_from_2020-09-18_14-27-08.png

155 KiB

hj commented

2020-09-24 11:51:57 +00:00

Member

ah... now i get it¹ it's the subject field that makes it grow, it also affects other inputs too, like search in the top and makes emoji reaction picker broken too.

TL note: "now i get it!" means "naruhodo" ↩︎

ah... now i get it![^TL] it's the subject field that makes it grow, it also affects other inputs too, like search in the top and makes emoji reaction picker broken too. [^TL]: TL note: "now i get it!" means "naruhodo"

hj referenced this issue from a pull request that will close it,

2026-02-06 05:31:04 +00:00

make subjectline input use size=1 for compatibility with CJK fonts #2528

Rows
Columns

Sidebar: Text input fields go too far #922