Moderation menu #310
Implements dropdown menu as per #310 (closed) discussion.
Video: https://cl.ly/bdd468fe1e58, menu auto-positioning: https://cl.ly/88373da97854 (the auto-positioning is optional FWIW)
Complementary backend MR for changing activation status API: pleroma!843 (merged)
Additional backend MR needed for the "deactivated" status in the user view pleroma!874 (merged) (should be merged first, the FE depends on it)
Visibility table. If an action is not applicable to the given user type, FE doesn't show it in the menu.
I have run tests on internal and external users to see which actions are applicable to which user type but corrections are welcome!
| Menu item | Applicable to user type | Video |
|---|---|---|
| Grant Admin | local | local user |
| Grant Moderator | local | local user |
| Deactivate account | local and external | local user external user |
| Delete account | local and external | local user external user from timeline |
| Force posts to be NSFW | local and external | local user external user |
| Force posts not to have media | local and external | local user external user |
| Force posts to be unlisted | local and external | local user external user |
| Force posts to be followers-only | local and external | local user external user |
| Disallow following user from remote instances | local | local user |
| Disallow following user at all | local |
"Disallow user posts from federating" - apparently it's not implemented yet, should we add it later?
Screenshots for different themes
| Themed dropdown menu | Themed Delete User dialog |
|---|---|
| Pleroma Dark | Pleroma Dark |
| Pleroma Light | Pleroma Light |
| Classic Dark | Classic Dark |
| Bird | Bird |
| Ir Black | Ir Black |
| Monokai | Monokai |
| Mammal | Mammal |
| Remond XX | Redmond XX |
| Breezy Dark | Breezy Dark |
| Breezy Light | Breezy Light |
Mobile: Light menu, Dark menu, Light Delete User dialog, Dark Delete User dialog
Mobile Video: https://cl.ly/115b0517fe3f
Merge request reports
Activity
mentioned in merge request pleroma!840 (merged)
mentioned in merge request pleroma!843 (merged)
added 25 commits
-
11821e0d...7b9a6f8d - 24 commits from branch
pleroma:develop - e6c6393e - Added moderation menu
-
11821e0d...7b9a6f8d - 24 commits from branch
added 14 commits
-
326878ac...22a0858e - 13 commits from branch
pleroma:develop - e55d1e3d - Added moderation menu
-
326878ac...22a0858e - 13 commits from branch
Yup, I'm not sure what are the alternatives when it comes to doing positioning with JS. I'd like to avoid adding too much code because of the cost associated with parsing and compiling it (bandwidth-wise, popper.js is only 6kb gzipped). But writing positioning logic ourselves while handling all the edge cases properly would probably result in something of a similar size I think.
Edited by EugenijWith regards to colors, is there a consensus on which colors should be used for the menu elements?
In the prototype, I went with the general background color to be consistent with the background color of a pressed button so that there is a visual connection between the two elements.
Also, the indicator appearance: Screen_Shot_2019-02-21_at_10.27.05_AM
I figured that for long labels, it might be clearer if we add the "ON" badge than if we change text (like in "Grant Admin" / "Revoke Admin").
The screenshots of how the menu looks in different themes:
