Verified Commit 1b79dce7 authored by minibikini's avatar minibikini
Browse files

Fix Reblog API

Do not set visibility parameter to `public` by default and let CommonAPI to infer it from status.
parent 732cc0ce
Pipeline #34180 passed with stages
in 9 minutes and 42 seconds
......@@ -117,7 +117,7 @@ def reblog_operation do
request_body("Parameters", %Schema{
type: :object,
properties: %{
visibility: %Schema{allOf: [VisibilityScope], default: "public"}
visibility: %Schema{allOf: [VisibilityScope]}
}
}),
responses: %{
......
......@@ -744,6 +744,17 @@ test "repeating a status privately" do
refute Visibility.visible_for_user?(announce_activity, nil)
end
test "author can repeat own private statuses" do
user = insert(:user)
{:ok, activity} = CommonAPI.post(user, %{status: "cofe", visibility: "private"})
{:ok, %Activity{} = announce_activity} = CommonAPI.repeat(activity.id, user)
assert Visibility.is_private?(announce_activity)
refute Visibility.visible_for_user?(announce_activity, nil)
end
test "favoriting a status" do
user = insert(:user)
other_user = insert(:user)
......
......@@ -954,6 +954,23 @@ test "reblogged status for another user" do
assert to_string(activity.id) == id
end
test "author can reblog own private status", %{conn: conn, user: user} do
{:ok, activity} = CommonAPI.post(user, %{status: "cofe", visibility: "private"})
conn =
conn
|> put_req_header("content-type", "application/json")
|> post("/api/v1/statuses/#{activity.id}/reblog")
assert %{
"reblog" => %{"id" => id, "reblogged" => true, "reblogs_count" => 1},
"reblogged" => true,
"visibility" => "private"
} = json_response_and_validate_schema(conn, 200)
assert to_string(activity.id) == id
end
end
describe "unreblogging" do
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment