Verified Commit 308b35eb authored by href's avatar href
Browse files

User.follow_all: ensure its stays unique

parent 44913c10
...@@ -315,7 +315,16 @@ def follow_all(follower, followeds) do ...@@ -315,7 +315,16 @@ def follow_all(follower, followeds) do
q = q =
from(u in User, from(u in User,
where: u.id == ^follower.id, where: u.id == ^follower.id,
update: [set: [following: fragment("array_cat(?, ?)", u.following, ^followed_addresses)]] update: [
set: [
following:
fragment(
"array(select distinct unnest (array_cat(?, ?)))",
u.following,
^followed_addresses
)
]
]
) )
{1, [follower]} = Repo.update_all(q, [], returning: true) {1, [follower]} = Repo.update_all(q, [], returning: true)
......
...@@ -65,6 +65,19 @@ test "follow_all follows mutliple users" do ...@@ -65,6 +65,19 @@ test "follow_all follows mutliple users" do
refute User.following?(user, not_followed) refute User.following?(user, not_followed)
end end
test "follow_all follows mutliple users without duplicating" do
user = insert(:user)
followed_zero = insert(:user)
followed_one = insert(:user)
followed_two = insert(:user)
{:ok, user} = User.follow_all(user, [followed_zero, followed_one])
assert length(user.following) == 3
{:ok, user} = User.follow_all(user, [followed_one, followed_two])
assert length(user.following) == 4
end
test "follow takes a user and another user" do test "follow takes a user and another user" do
user = insert(:user) user = insert(:user)
followed = insert(:user) followed = insert(:user)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment