Commit 47ec690c authored by lain's avatar lain
Browse files

Use race-condition free mass follow.

parent 935e65e2
Pipeline #6798 failed with stages
in 3 minutes and 32 seconds
......@@ -309,20 +309,21 @@ def maybe_follow(%User{} = follower, %User{info: _info} = followed) do
@doc "A mass follow for local users. Ignores blocks and has no side effects"
@spec follow_all(User.t(), list(User.t())) :: {atom(), User.t()}
def follow_all(follower, followeds) do
following =
(follower.following ++, fn %{follower_address: fa} -> fa end))
|> Enum.uniq()
followed_addresses =, fn %{follower_address: fa} -> fa end)
q =
from(u in User,
where: == ^,
update: [set: [following: fragment("array_cat(?, ?)", u.following, ^followed_addresses)]]
{:ok, follower} =
|> follow_changeset(%{following: following})
|> update_and_set_cache
{1, [follower]} = Repo.update_all(q, [], returning: true)
Enum.each(followeds, fn followed ->
{:ok, follower}
def follow(%User{} = follower, %User{info: info} = followed) do
......@@ -50,13 +50,19 @@ test "ap_followers returns the followers collection for the user" do
test "follow_all follows mutliple users" do
user = insert(:user)
followed_zero = insert(:user)
followed_one = insert(:user)
followed_two = insert(:user)
not_followed = insert(:user)
{:ok, user} = User.follow(user, followed_zero)
{:ok, user} = User.follow_all(user, [followed_one, followed_two])
assert User.following?(user, followed_one)
assert User.following?(user, followed_two)
assert User.following?(user, followed_zero)
refute User.following?(user, not_followed)
test "follow takes a user and another user" do
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment