Commit 5f7901cc authored by feld's avatar feld
Browse files

Credo

parent 2a47156b
Pipeline #36533 passed with stages
in 10 minutes and 40 seconds
...@@ -80,10 +80,11 @@ defp build_attachments(%{data: %{"attachment" => attachments}}) do ...@@ -80,10 +80,11 @@ defp build_attachments(%{data: %{"attachment" => attachments}}) do
| acc | acc
] ]
# Not using preview_url for this. It saves bandwidth, but the image dimensions will be wrong. # Not using preview_url for this. It saves bandwidth, but the image dimensions will
# We generate it on the fly and have no way to capture or analyze the image to get the dimensions. # be wrong. We generate it on the fly and have no way to capture or analyze the
# This can be an issue for apps/FEs rendering images in timelines too, but you can get clever with # analyze the image to get the dimensions. This can be an issue for apps/FEs
# the aspect ratio metadata as a workaround. # rendering images in timelines too, but you can get clever with the aspect ratio
# metadata as a workaround.
"image" -> "image" ->
[ [
{:meta, [property: "og:image", content: MediaProxy.url(url["href"])], []}, {:meta, [property: "og:image", content: MediaProxy.url(url["href"])], []},
......
...@@ -67,10 +67,11 @@ defp build_attachments(id, %{data: %{"attachment" => attachments}}) do ...@@ -67,10 +67,11 @@ defp build_attachments(id, %{data: %{"attachment" => attachments}}) do
| acc | acc
] ]
# Not using preview_url for this. It saves bandwidth, but the image dimensions will be wrong. # Not using preview_url for this. It saves bandwidth, but the image dimensions will
# We generate it on the fly and have no way to capture or analyze the image to get the dimensions. # be wrong. We generate it on the fly and have no way to capture or analyze the
# This can be an issue for apps/FEs rendering images in timelines too, but you can get clever with # analyze the image to get the dimensions. This can be an issue for apps/FEs
# the aspect ratio metadata as a workaround. # rendering images in timelines too, but you can get clever with the aspect ratio
# metadata as a workaround.
"image" -> "image" ->
[ [
{:meta, [property: "twitter:card", content: "summary_large_image"], []}, {:meta, [property: "twitter:card", content: "summary_large_image"], []},
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment