Commit 7d34cec5 authored by lain's avatar lain
Browse files

escape attachment urls on creation.

parent a32784fe
......@@ -12,7 +12,7 @@ def attachments_from_ids(ids) do
def add_attachments(text, attachments) do
attachment_text = Enum.map(attachments, fn
(%{"url" => [%{"href" => href} | _]}) ->
"<a href=\"#{URI.encode(href)}\" class='attachment'>#{Path.basename(href)}</a>"
"<a href=\"#{href}\" class='attachment'>#{Path.basename(href)}</a>"
_ -> ""
end)
Enum.join([text | attachment_text], "<br>\n")
......
......@@ -9,6 +9,6 @@ test "it adds attachment links to a given text and attachment set" do
res = Utils.add_attachments("", [attachment])
assert res == "<br>\n<a href=\"http://heise.de/i%22m%20a%20boy.png\" class='attachment'>i\"m a boy.png</a>"
assert res == "<br>\n<a href=\"http://heise.de/i\"m a boy.png\" class='attachment'>i\"m a boy.png</a>"
end
end
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment