Commit 88a4de24 authored by lain's avatar lain
Browse files

User.follow_all: Respect blocks in both directions.

parent 33f8f3c3
Pipeline #7560 passed with stages
in 6 minutes and 16 seconds
......@@ -311,12 +311,12 @@ def maybe_follow(%User{} = follower, %User{info: _info} = followed) do
@doc "A mass follow for local users. Respects blocks but does not create activities."
@doc "A mass follow for local users. Respects blocks in both directions but does not create activities."
@spec follow_all(User.t(), list(User.t())) :: {atom(), User.t()}
def follow_all(follower, followeds) do
followed_addresses =
|> Enum.reject(fn %{ap_id: ap_id} -> ap_id in end)
|> Enum.reject(fn followed -> blocks?(follower, followed) || blocks?(followed, follower) end)
|> %{follower_address: fa} -> fa end)
q =
......@@ -55,18 +55,21 @@ test "follow_all follows mutliple users" do
followed_two = insert(:user)
blocked = insert(:user)
not_followed = insert(:user)
reverse_blocked = insert(:user)
{:ok, user} = User.block(user, blocked)
{:ok, reverse_blocked} = User.block(reverse_blocked, user)
{:ok, user} = User.follow(user, followed_zero)
{:ok, user} = User.follow_all(user, [followed_one, followed_two, blocked])
{:ok, user} = User.follow_all(user, [followed_one, followed_two, blocked, reverse_blocked])
assert User.following?(user, followed_one)
assert User.following?(user, followed_two)
assert User.following?(user, followed_zero)
refute User.following?(user, not_followed)
refute User.following?(user, blocked)
refute User.following?(user, reverse_blocked)
test "follow_all follows mutliple users without duplicating" do
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment