Commit b82637f3 authored by lain's avatar lain

Don't use special query for feed.

parent d2ad9929
Pipeline #875 passed with stage
in 2 minutes and 27 seconds
...@@ -7,6 +7,7 @@ defmodule Pleroma.Web.OStatus.OStatusController do ...@@ -7,6 +7,7 @@ defmodule Pleroma.Web.OStatus.OStatusController do
alias Pleroma.Web.{OStatus, Federator} alias Pleroma.Web.{OStatus, Federator}
alias Pleroma.Web.XML alias Pleroma.Web.XML
alias Pleroma.Web.ActivityPub.ActivityPubController alias Pleroma.Web.ActivityPub.ActivityPubController
alias Pleroma.Web.ActivityPub.ActivityPub
import Ecto.Query import Ecto.Query
def feed_redirect(conn, %{"nickname" => nickname} = params) do def feed_redirect(conn, %{"nickname" => nickname} = params) do
...@@ -21,14 +22,9 @@ def feed_redirect(conn, %{"nickname" => nickname} = params) do ...@@ -21,14 +22,9 @@ def feed_redirect(conn, %{"nickname" => nickname} = params) do
def feed(conn, %{"nickname" => nickname} = params) do def feed(conn, %{"nickname" => nickname} = params) do
user = User.get_cached_by_nickname(nickname) user = User.get_cached_by_nickname(nickname)
query = from activity in Activity,
where: fragment("?->>'actor' = ?", activity.data, ^user.ap_id),
limit: 20,
order_by: [desc: :id]
activities = query activities = ActivityPub.fetch_public_activities(%{"whole_db" => true, "actor_id" => user.ap_id})
|> restrict_max(params) |> Enum.reverse
|> Repo.all
response = user response = user
|> FeedRepresenter.to_simple_form(activities, [user]) |> FeedRepresenter.to_simple_form(activities, [user])
...@@ -57,11 +53,6 @@ defp decode_or_retry(body) do ...@@ -57,11 +53,6 @@ defp decode_or_retry(body) do
end end
end end
defp restrict_max(query, %{"max_id" => max_id}) do
from activity in query, where: activity.id < ^max_id
end
defp restrict_max(query, _), do: query
def salmon_incoming(conn, _) do def salmon_incoming(conn, _) do
{:ok, body, _conn} = read_body(conn) {:ok, body, _conn} = read_body(conn)
{:ok, doc} = decode_or_retry(body) {:ok, doc} = decode_or_retry(body)
...@@ -72,6 +63,7 @@ def salmon_incoming(conn, _) do ...@@ -72,6 +63,7 @@ def salmon_incoming(conn, _) do
|> send_resp(200, "") |> send_resp(200, "")
end end
# TODO: Data leak
def object(conn, %{"uuid" => uuid} = params) do def object(conn, %{"uuid" => uuid} = params) do
if get_format(conn) == "activity+json" do if get_format(conn) == "activity+json" do
ActivityPubController.object(conn, params) ActivityPubController.object(conn, params)
...@@ -87,6 +79,7 @@ def object(conn, %{"uuid" => uuid} = params) do ...@@ -87,6 +79,7 @@ def object(conn, %{"uuid" => uuid} = params) do
end end
end end
# TODO: Data leak
def activity(conn, %{"uuid" => uuid}) do def activity(conn, %{"uuid" => uuid}) do
with id <- o_status_url(conn, :activity, uuid), with id <- o_status_url(conn, :activity, uuid),
%Activity{} = activity <- Activity.get_by_ap_id(id), %Activity{} = activity <- Activity.get_by_ap_id(id),
...@@ -98,6 +91,7 @@ def activity(conn, %{"uuid" => uuid}) do ...@@ -98,6 +91,7 @@ def activity(conn, %{"uuid" => uuid}) do
end end
end end
# TODO: Data leak
def notice(conn, %{"id" => id}) do def notice(conn, %{"id" => id}) do
with %Activity{} = activity <- Repo.get(Activity, id), with %Activity{} = activity <- Repo.get(Activity, id),
%User{} = user <- User.get_cached_by_ap_id(activity.data["actor"]) do %User{} = user <- User.get_cached_by_ap_id(activity.data["actor"]) do
......
...@@ -43,7 +43,7 @@ test "gets a feed", %{conn: conn} do ...@@ -43,7 +43,7 @@ test "gets a feed", %{conn: conn} do
conn = conn conn = conn
|> get("/users/#{user.nickname}/feed.atom") |> get("/users/#{user.nickname}/feed.atom")
assert response(conn, 200) assert response(conn, 200) =~ note_activity.data["object"]["content"]
end end
test "gets an object", %{conn: conn} do test "gets an object", %{conn: conn} do
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment