Commit c464355d authored by lain's avatar lain
Browse files

Idempotency: Use special cache, keep for 6 hours.

parent 762f6edc
Pipeline #1645 passed with stages
in 4 minutes and 40 seconds
......@@ -23,6 +23,18 @@ def start(_type, _args) do
limit: 2500
]
]),
worker(
Cachex,
[
:idempotency_cache,
[
default_ttl: :timer.seconds(6 * 60 * 60),
ttl_interval: :timer.seconds(60),
limit: 2500
]
],
id: :cachex_idem
),
worker(Pleroma.Web.Federator, []),
worker(Pleroma.Gopher.Server, []),
worker(Pleroma.Stats, [])
......
......@@ -283,13 +283,11 @@ def post_status(%{assigns: %{user: user}} = conn, %{"status" => _} = params) do
{:ok, activity} =
Cachex.get!(
:user_cache,
"idem:#{idempotency_key}",
:idempotency_cache,
idempotency_key,
fallback: fn _ -> CommonAPI.post(user, params) end
)
Cachex.expire(:user_cache, "idem:#{idempotency_key}", :timer.seconds(5 * 60))
render(conn, StatusView, "status.json", %{activity: activity, for: user, as: :activity})
end
......
......@@ -75,9 +75,9 @@ test "posting a status", %{conn: conn} do
"sensitive" => "false"
})
{:ok, ttl} = Cachex.ttl(:user_cache, "idem:#{idempotency_key}")
# 5 Minutes
assert ttl > :timer.seconds(5 * 60 - 1)
{:ok, ttl} = Cachex.ttl(:idempotency_cache, idempotency_key)
# Six hours
assert ttl > :timer.seconds(6 * 60 * 60 - 1)
assert %{"content" => "cofe", "id" => id, "spoiler_text" => "2hu", "sensitive" => false} =
json_response(conn_one, 200)
......@@ -97,6 +97,19 @@ test "posting a status", %{conn: conn} do
assert %{"id" => second_id} = json_response(conn_two, 200)
assert id == second_id
conn_three =
conn
|> assign(:user, user)
|> post("/api/v1/statuses", %{
"status" => "cofe",
"spoiler_text" => "2hu",
"sensitive" => "false"
})
assert %{"id" => third_id} = json_response(conn_three, 200)
refute id == third_id
end
test "posting a sensitive status", %{conn: conn} do
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment