Skip to content
GitLab
  1. 28 Sep, 2018 2 commits
  3. 24 Sep, 2018 2 commits
    • kaniini's avatar
      Merge branch 'fix/s3/filenames-with-spaces' into 'develop' · 3de12c19
      kaniini authored 
      Uploaders.S3: Replace unsafe characters in object key

See merge request !359
      3de12c19
    • Martin's avatar
      Uploaders.S3: Replace unsafe characters in object key · f77ec967
      Martin authored 
      According to [the S3 docs][s3], the characters safe for use in object keys are:

* 0-9
* a-z
* A-Z
* !
* -
* _
* .
* *
* '
* (
* )

(The / character is not listed but mentioned being safe outside of the list.)

Several characters that are valid in filenames can cause problems, for example
spaces are not valid in URLs and need to be escaped,
sequences of spaces can become squeezed by S3,
some characters like \ are documented to require “significant special handling”.

To avoid these problems, this change encodes the filename
before using it as part of the S3 object name
by replacing all characters except those documented as “safe” with dashes.

[s3]: https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingMetadata.html
      f77ec967
  5. 22 Sep, 2018 15 commits
  7. 21 Sep, 2018 1 commit
  9. 20 Sep, 2018 12 commits
  11. 19 Sep, 2018 3 commits
  13. 18 Sep, 2018 1 commit
  15. 17 Sep, 2018 1 commit
  17. 16 Sep, 2018 3 commits