Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 647
    • Issues 647
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 90
    • Merge requests 90
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Issues
  • #715
Closed
Open
Issue created Mar 06, 2019 by rinpatch@rinpatchContributor

Make dedupe return correct filenames and enable it by default

The only thing preventing dedupe from being enabled by default is that it messes with the filenames. The solution would be to put a Content-Disposition header with the desired filename.

However with dedupe one attachment can be tied to multiple posts, the solution would be to make pleroma-fe add a name url parameter in the query string. For example if the backend returns

{
  "description": "cofe.gif",
  "id": "1765902618",
  "preview_url": "https://patch.cx/media/fa82492fa0748bc2eefe2094fe8d307f77729252a4cc8eacd0673271e7c72e64.gif",
  "remote_url": "https://patch.cx/media/fa82492fa0748bc2eefe2094fe8d307f77729252a4cc8eacd0673271e7c72e64.gif",
  "text_url": "https://patch.cx/media/fa82492fa0748bc2eefe2094fe8d307f77729252a4cc8eacd0673271e7c72e64.gif",
  "type": "image",
  "url": "https://patch.cx/media/fa82492fa0748bc2eefe2094fe8d307f77729252a4cc8eacd0673271e7c72e64.gif"
}

the frontend should link the attachment as https://patch.cx/media/fa82492fa0748bc2eefe2094fe8d307f77729252a4cc8eacd0673271e7c72e64.gif?name=cofe.gif

not sure that's the best approach to this so, cc: @lambadalambda @shpuld

Edited Mar 07, 2019 by rinpatch
Assignee
Assign to
Time tracking