Skip to content

Fix a compilation error under certain circumstances

rinpatch requested to merge fix/compilation-error-docs into develop

I've noticed that sometimes when switching from develop to stable and back, develop fails to compile and rm -r ing the _build and deps dirs doesn't help at all.

This is due to Admin API controller needing to generate JSON description of the config at compile time. Evaluating config/description.exs calls Generator.list_modules_in_dir/2, which in turn predicts the module names of files in the directory and tries to convert the predicted name to existing atoms. Sometimes the compiler will call that function before compiling the modules in the said directory, so the conversion will of course fail.

This fixes it by removing the requirement of the atoms being existent. The function is not subjected to any untrusted user input so this should be safe. An ideal fix would be to block the compilation of docs before all modules are compiled and then get a list of compiled elixir modules under the namespace we want instead of directory hacks, but I have not been able to figure out how to do that.

Merge request reports