Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 646
    • Issues 646
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 88
    • Merge requests 88
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !2354

[#1559] Support for "follow_request" notifications

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ivan Tashkinov requested to merge 1559-follow-request-notifications into develop Apr 07, 2020
  • Overview 19
  • Commits 5
  • Pipelines 5
  • Changes 10

Closes #1559 (closed):

  • prevents "... followed you" notifications for pending follows
  • adds support for follow request notifications

FE issue: pleroma-fe#823 (closed)

Note: follow_request notifications aren't currently supported by PleromaFE (and cause issues like any other unrecognized notifications, see pleroma-fe#822 (closed)), thus disabled by default. This causes no follow / follow_request notifications for pending follows.

With follow_request notifications enabled, they are created for pending follows. Accepting a follow doesn't generate new notification (intentionally, since accepting is a user-initiated action, and accepter doesn't need to be notified on own action) but previous notification (initially having type: "follow_request") will be rendered with type: "follow" (as reflected in tests).

To enable, add config :pleroma, :notifications, enable_follow_request_notifications: true to config/dev.secret.exs.

P.S. This MR is fully compatible with existing and previous versions of PleromaFE, as is (since it disables [:notifications, :enable_follow_request_notifications]). Thus, it's mergeable independently from PleromaFE updates. ;)

Edited Apr 08, 2020 by Ivan Tashkinov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1559-follow-request-notifications