Skip to content

Always accept deletions through SimplePolicy, add :reject_deletes group

Alex Gleason requested to merge alexgleason/pleroma:accept-deletes into develop

!2037 (merged) allowed Delete activities to pass through MRF. Previously deletions would always be accepted by Pleroma servers and it was not possible to modify or drop them.

As a possibly unintended side-effect, it changed the default behavior of SimplePolicy to reject deletions from any server configured under the reject group (and the inverse for accept for whitelist federation).

In practice this means if a server bans you, your posts are stuck on the remote server forever. If you delete your account or your old posts, the remote server won't fulfill your request. I think most users don't want this behavior. I think probably the remote server doesn't want this either since they reject content they don't want to see, and would probably rather accept deletions automatically than respond to email requests for deletions.

This MR allows all deletions through SimplePolicy regardless of settings. If for whatever reason an admin wants to reject deletion requests they could add another MRF or comment the 2 lines of code I added, but I think the default for SimplePolicy should be to accept all deletions. SimplePolicy is the most common MRF used by many servers so the default behavior matters.

Thanks!

Edited by Alex Gleason

Merge request reports