Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 593
    • Issues 593
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 96
    • Merge requests 96
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Pleroma
  • pleromapleroma
  • Merge requests
  • !2636

StatusController: Correctly paginate favorites.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged lain requested to merge 1851-favorites-pagination into develop Jun 09, 2020
  • Overview 14
  • Commits 8
  • Pipelines 8
  • Changes 5

Favorites were paginating wrongly, because the pagination headers where using the id of the id of the Create activity, while the ordering was by the id of the Like activity. This isn't easy to notice in most cases, as they usually have a similar order because people tend to favorite posts as they come in. This commit adds a way to give different pagination ids to the pagination helper, so we can paginate correctly in cases like this.

Closes #1851 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 1851-favorites-pagination