Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 646
    • Issues 646
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 86
    • Merge requests 86
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !3124

Remove release_env

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged rinpatch requested to merge remove/release-env into develop Nov 07, 2020
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 9

While taking a final look at instance.gen before releasing I noticed that the release_env task outputs messages in broken english. Upon further inspection it seems to have even more severe issues which, in my opinion, warrant it's at least temporary removal:

  • We do not explain what it actually does, anywhere. Neither the task docs nor instance.gen, nor installation instructions.
  • It does not respect FHS on OTP releases (uses /opt/pleroma/config even though we store the config in /etc/pleroma/config.exs).
  • It doesn't work on OTP releases, which is the main reason it exists. Neither systemd nor openrc service files for OTP include it.
  • It is not mentioned in install guides other than the ones for Debian and OTP releases.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: remove/release-env