Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 645
    • Issues 645
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 88
    • Merge requests 88
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !3400

Don't crash so hard when email settings are invalid

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alex Gleason requested to merge dont-crash-email-settings into develop May 03, 2021
  • Overview 0
  • Commits 3
  • Pipelines 2
  • Changes 4

Premise: Users should be able to configure their site through AdminFE without ever touching the command line. This is a requirement for Tribes to be able to function.

Crashing hard for invalid email config makes this impossible. Instead we should just roll with the invalid config, warn the user on bootup, and let things fail when they fail. AdminFE should also never let invalid config be saved in the first place (see: admin-fe#192)

Rather than crashing at startup, I've converted those errors into logger warnings. I've also added a test to ensure that things still work even with the invalid config (emails aren't sent of course, but the user is still successfully registered).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dont-crash-email-settings