Skip to content

Recompilation speedup: Create real Views for all Controllers

Alex Gleason requested to merge cycles-views into develop

#2651 (closed)

Another impactful change, this kills 6 cycles on its own: https://www.diffchecker.com/TG1TwRoP

Screenshot_from_2021-05-29_12-24-02

Using plug(:put_view, ...) in a controller creates a compile-time dep on that view.

This can create cycles, but also just makes controllers recompile unnecessarily.

We can fix this by creating a separate View file for each controller, then calling the desired view internally. This gives us more flexibility to alter views for different controllers, and also makes views into runtime deps.

Merge request reports