Skip to content

Recompilation speedup: Break out activity-specific HTML functions into Pleroma.Activity.HTML

Alex Gleason requested to merge cycles-html into develop

#2651 (closed)

Gets rid of a compile-time cycle and shrinks many others: https://www.diffchecker.com/n1Sru9kA

Screenshot_from_2021-05-29_12-36-11

ChatMessageValidator has a compile-time dep on SafeText (not much we can do about that).

SafeText depends on Pleroma.HTML which depends on Activity, creating compile-time cycles.

The solution is to keep Pleroma.HTML very simple and break out activity-related functions into a separate module, Pleroma.Activity.HTML.

Merge request reports