Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 645
    • Issues 645
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 86
    • Merge requests 86
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !409

object cache deletion refactoring, part 2

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged kaniini requested to merge refactor/object-cache-deletion into develop Nov 01, 2018
  • Overview 0
  • Commits 6
  • Pipelines 8
  • Changes 7

these changes concern how objects which interact with Cachex are managed. to ensure we do not have zombie objects returning, we should never ever directly delete the objects with Repo.delete, and instead use object-specific deleters.

in this MR:

  • Object.delete() cleanups pointed out by lain
  • User.invalidate_cache() now deletes zombie user_info data.
  • User.delete() now returns {:ok, deleted_user} to match Object.delete().
  • Object cache is now split from User cache.
  • Regression tests for user deletion + cache interactions.
Edited Nov 01, 2018 by kaniini
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: refactor/object-cache-deletion