Skip to content

Fix WebPush actor regression

feld requested to merge fix-webpush-actor into develop

When cleaning up webpush on the path to better notifications for polls in !4144 (merged) I accidentally broke the logic causing every mention/favorite/etc type notification to begin with your nickname instead of the originating user.

e.g., "@feld: @feld hey how are you today"

instead of "@lain: @feld hey how are you today"

The existing tests were built to do basic validation of the construction of the message contents and did not fully exercise the notification through webpush payload path because we did all the build and push work inside the perform/1 function.

This has now been split up into build and deliver functions so it can be more thoroughly tested.

Merge request reports