Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 580
    • Issues 580
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 97
    • Merge requests 97
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Pleroma
  • pleromapleroma
  • Merge requests
  • !883

Use sql query in User.get_follow_requests/1 for filtering logic

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eugenij requested to merge eugenijm/pleroma:get-follow-requests-sql into develop Mar 02, 2019
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 2

get_follow_requests can become slower as the amount of followers grows. Debugging showed that get_follow_requests fetches all user follow activities and filters them in app memory. Follow activities are created on every follow request (regardless of whether the user is locked or not, and their state isn't changed from 'pending' once the follow request is accepted), so for a user with N followers, it has to filter through N follow activities.

Edited Mar 02, 2019 by Eugenij
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: get-follow-requests-sql