pleroma.user unsubscribe mix task behaves oddly #749

Closed
opened 2019-03-22 22:06:43 +00:00 by feld · 7 comments
Owner

I suspect the intention of the mix pleroma.user unsubscribe <user> task is to unsubscribe local users from the specified user. I just tried to see what happens if I unsubscribe a remote user that I disabled/blocked on my instance and it appeared to be trying to unsubscribe every user on my instance -- remote accounts included.

How exactly is this supposed to work? It seems to be missing some constraints.

I suspect the intention of the `mix pleroma.user unsubscribe <user>` task is to unsubscribe local users from the specified user. I just tried to see what happens if I unsubscribe a remote user that I disabled/blocked on my instance and it appeared to be trying to unsubscribe every user on my instance -- remote accounts included. How exactly is this supposed to work? It seems to be missing some constraints.
Member

it unsubscribes all local users from the given target, yes. maybe it got broken when it was moved to pleroma.user namespace

it unsubscribes all local users from the given target, yes. maybe it got broken when it was moved to pleroma.user namespace

The description of this is really weird. What this does is

  1. take a user (local or remote)
  2. get all the friends (aka people who that user followers), local or remote
  3. then unfollows all those friends

So what it is is a way to deactivate a user and make them follow nobody. Did you guys understand it like this as well?

The description of this is really weird. What this does is 1. take a user (local or remote) 2. get all the friends (aka people who that user followers), local or remote 3. then unfollows all those friends So what it is is a way to deactivate a user and make them follow nobody. Did you guys understand it like this as well?

comment from kaniini on irc:

[10:11:45 am] <kaniini> it does the right thing it's just badly described
[10:11:52 am] <kaniini> it's for when you suspend a remote user
[10:12:02 am] <kaniini> to make sure that any subscriptions are removed
comment from kaniini on irc: ``` [10:11:45 am] <kaniini> it does the right thing it's just badly described [10:11:52 am] <kaniini> it's for when you suspend a remote user [10:12:02 am] <kaniini> to make sure that any subscriptions are removed ```
Member

If that is the case then, it is not checked whether the user is remote or local right now.

If that is the case then, it is not checked whether the user is remote or local right now.
Member

yeah it's something i made quickly because there was a remote instance that was scraping everyone's posts, so people asked for a way to deal with it

yeah it's something i made quickly because there was a remote instance that was scraping everyone's posts, so people asked for a way to deal with it
Owner

@feld (as you're assigned) Any news on this?

@feld (as you're assigned) Any news on this?
Author
Owner

I think we just need to limit this to local users only

edit: actually would it be fair to just remove this mix task and make suspending a user account do this automatically?

I think we just need to limit this to local users only edit: actually would it be fair to just remove this mix task and make suspending a user account do this automatically?
Sign in to join this conversation.
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma#749
No description provided.