Downgrade Hackney #7860
No reviewers
Labels
No labels
AP C2S
AdminAPI
Breaking API
Breaks existing config
Check if still valid
Data Protection
Do not merge
Document in the changelog
Doing
Feature Request / Enhancement
MastoAPI
NL2
NL4
OStatus
OTP Releases
Refactor
Security
To Do
TwitterAPI
bug
complicated
confirmed
deps
discussion
documentation
easy
feature: to be merged in stable
fix: to be merged in stable
incident
needs to be backported to maint
needs-changes
needs-info
needs-review
performance
regression
unclear
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
pleroma/pleroma!7860
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "hackney-downgrade"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
It appears the implementation of Happy Eyeballs in 1.22.0 is the origin of
some pretty serious performance regressions that remain even in the latest
Hackney 3.0 branch.
Connection tests:
=== 1.22.0 ===
First call: 9434ms
Second call: 14ms
=== 1.21.0 ===
First call: 228ms
Second call: 16ms
Checklist
changelog.ddirectory, create a file named<code>.<type>.d86a43afef60b03191f0from my testing with a simple mix task that profiles Webfinger lookups
Summary about various recent Hackney-related issues so info isn't scattered throughout multiple issues and fedi threads:
6bbfba7f6e) that causes faulty{:error, :checkout_timeout}errors when processing outgoing federation jobs, or fetching/refreshing Actors. (#7834){:error, :checkout_timeout}errors when used as client for MediaProxy; it is currently unclear if that is caused by a regression in that version of Hackney, or due to high server load.ssl_optionsin the configuration file or ConfigDB. (#7824)Due to the above, 1.20.1 might be a better version to downgrade to since it possibly does not have the
ssl_optionsregression, although I have no way to confirm that since I could not reproduce the issue and I don't have a Mailgun account to test with.Also when I thought about this more. The long wait could be possibly related to the default
connect_timeoutin Hackney being way too long (8 seconds). Try lowering that and see if the times change and check if the host you are connecting to actually has working IPv6 besides AAAA records.https://hexdocs.pm/hackney/1.25.0/hackney.html#request/5
@phnt wrote in #7860 (comment):
tried playing with these Hackney timeout values when doing my testing, it didn't affect the results. And my test was against a webfinger lookup of @fakeaccount@friedcheese.us which is ~1ms away from my laptop, no AAAA records at all.
60b03191f07582b71f46Back to 1.20.1 it is, then!