pleroma/pleroma
4
6
Fork 12
Code Issues 720 Pull requests 83 Projects Releases 1 Packages Wiki Activity

WIP: Fix account favourites ordering #7914

Draft
lambadalambda wants to merge 1 commit from issue-3379-favourites-order into develop
pull from: issue-3379-favourites-order
merge into: pleroma:develop
Conversation 0 Commits 1 Files changed 3 +90 -12
lambadalambda commented 2026-05-25 14:13:37 +00:00
Owner
Copy link

Summary

  • Order account favourites by Like activity id/date instead of status id/date.
  • Use Like activity ids for keyset pagination and Link headers.
  • Add regression tests for ordering, since_id/max_id, min_id, and limit behavior.

Fixes #3379

Testing

  • podman run ... mix test test/pleroma/web/pleroma_api/controllers/account_controller_test.exs (19 tests, 0 failures)
  • podman run ... docker.io/elixir:1.15-alpine mix format --check-formatted
  • Isolated non-root podman full suite: 4814 tests, 0 failures, 2 excluded, 4 skipped

Notes

  • Local root-container full-suite runs are not authoritative for this repo because root can bypass the emoji permission-negative test; the isolated non-root run matches CI behavior better.
## Summary - Order account favourites by Like activity id/date instead of status id/date. - Use Like activity ids for keyset pagination and Link headers. - Add regression tests for ordering, since_id/max_id, min_id, and limit behavior. Fixes #3379 ## Testing - `podman run ... mix test test/pleroma/web/pleroma_api/controllers/account_controller_test.exs` (19 tests, 0 failures) - `podman run ... docker.io/elixir:1.15-alpine mix format --check-formatted` - Isolated non-root podman full suite: `4814 tests, 0 failures, 2 excluded, 4 skipped` ## Notes - Local root-container full-suite runs are not authoritative for this repo because root can bypass the emoji permission-negative test; the isolated non-root run matches CI behavior better.
Fix account favourites ordering
All checks were successful
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/docker-armv7 Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline was successful
Details
a84d16831f
All checks were successful
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/docker-armv7 Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline was successful
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin issue-3379-favourites-order:issue-3379-favourites-order
git switch issue-3379-favourites-order

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop
git merge --no-ff issue-3379-favourites-order
git switch issue-3379-favourites-order
git rebase develop
git switch develop
git merge --ff-only issue-3379-favourites-order
git switch issue-3379-favourites-order
git rebase develop
git switch develop
git merge --no-ff issue-3379-favourites-order
git switch develop
git merge --squash issue-3379-favourites-order
git switch develop
git merge --ff-only issue-3379-favourites-order
git switch develop
git merge issue-3379-favourites-order
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AP C2S

   
AdminAPI

   
Breaking API
Affects clients

  
Breaks existing config

   
Check if still valid

   
Data Protection

   
Do not merge

   
Document in the changelog

   
Doing

   
Feature Request / Enhancement

   
MastoAPI

   
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
OStatus

   
OTP Releases

   
Refactor

   
Security

   
To Do

   
TwitterAPI

   
bug

   
complicated

   
confirmed

   
deps

   
discussion

   
documentation

   
easy

   
feature: to be merged in stable

   
fix: to be merged in stable

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
needs to be backported to maint

   
needs-changes

   
needs-info

   
needs-review

   
performance

   
regression

   
unclear
No labels
AP C2S
AdminAPI
Breaking API
Breaks existing config
Check if still valid
Data Protection
Do not merge
Document in the changelog
Doing
Feature Request / Enhancement
MastoAPI
NL2
NL4
OStatus
OTP Releases
Refactor
Security
To Do
TwitterAPI
bug
complicated
confirmed
deps
discussion
documentation
easy
feature: to be merged in stable
fix: to be merged in stable
incident
needs to be backported to maint
needs-changes
needs-info
needs-review
performance
regression
unclear
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma!7914
No description provided.