WIP: Fix clear_config warnings being dropped #8002

Draft
phnt wants to merge 2 commits from clear-config-fixups into develop
Member

Logger.warning keeps dropping warning messages from clear_config for some reason,
replaced with IO.warn which also gives us the location of the triggering caller.

TODO

  • Check all warnings for validity, replace with new clear_config_quiet if valid

Checklist

  • Adding a changelog: In the changelog.d directory, create a file named <code>.<type>.
`Logger.warning` keeps dropping warning messages from `clear_config` for some reason, replaced with `IO.warn` which also gives us the location of the triggering caller. ### TODO - [ ] Check all warnings for validity, replace with new `clear_config_quiet` if valid ### Checklist - [x] Adding a changelog: In the `changelog.d` directory, create a file named `<code>.<type>`. <!-- `<code>` can be anything, but we recommend using a more or less unique identifier to avoid collisions, such as the branch name. `<type>` can be `add`, `change`, `remove`, `fix`, `security` or `skip`. `skip` is only used if there is no user-visible change in the PR (for example, only editing comments in the code). Otherwise, choose a type that corresponds to your change. In the file, write the changelog entry. For example, if a PR adds group functionality, we can create a file named `group.add` and write `Add group functionality` in it. If one changelog entry is not enough, you may add more. But that might mean you can split it into two PRs. Only use more than one changelog entry if you really need to (for example, when one change in the code fix two different bugs, or when refactoring). -->
Only use this when the warned about usage in clear_config is desired!
Test Helpers: Replace Logger.warning with IO.warn in clear_config
All checks were successful
ci/woodpecker/pr/changelog Pipeline was successful
ci/woodpecker/pr/lint Pipeline was successful
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was successful
ci/woodpecker/pr/unit-testing-elixir-1.19 Pipeline was successful
f816afea1e
Logger is dropping messages during the test suite runs for some reason.
As a side-effect we get the actual location of the caller triggering the
warning.
All checks were successful
ci/woodpecker/pr/changelog Pipeline was successful
ci/woodpecker/pr/lint Pipeline was successful
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was successful
ci/woodpecker/pr/unit-testing-elixir-1.19 Pipeline was successful
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin clear-config-fixups:clear-config-fixups
git switch clear-config-fixups

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop
git merge --no-ff clear-config-fixups
git switch clear-config-fixups
git rebase develop
git switch develop
git merge --ff-only clear-config-fixups
git switch clear-config-fixups
git rebase develop
git switch develop
git merge --no-ff clear-config-fixups
git switch develop
git merge --squash clear-config-fixups
git switch develop
git merge --ff-only clear-config-fixups
git switch develop
git merge clear-config-fixups
git push origin develop
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma!8002
No description provided.