Skip to content
Snippets Groups Projects
  1. Apr 24, 2022
  2. Mar 30, 2022
  3. Mar 20, 2022
  4. Mar 19, 2022
  5. Mar 17, 2022
  6. Mar 07, 2022
    • Ilja's avatar
      After code review · cdc5bbe8
      Ilja authored
      Use patern matching to see if someone was superuser before
      cdc5bbe8
  7. Mar 06, 2022
  8. Mar 03, 2022
  9. Mar 02, 2022
  10. Mar 01, 2022
  11. Feb 28, 2022
  12. Feb 26, 2022
  13. Feb 25, 2022
  14. Feb 22, 2022
    • Ilja's avatar
      Fix test get_user_apps/1 · 6ba93c2c
      Ilja authored
      For some reason I had a test who suddenly failed, mix test test/pleroma/web/o_auth/app_test.exs:54. A user has a list of applications and this test adds them and then sees if the list it gets back is the same as the apps it added.
      
      When I ran mix test a day before I didn't have this problem and when I pushed code today in a different MR, the pipeline succeeded (see https://git.pleroma.social/ilja/pleroma/-/jobs/205827), yet locally it failed. So it seems the test can sometimes succeed and sometimes fail, which makes it untrustworthy.
      
      The failure I see is because the returned list is in reverse order. I assume that's not per sé wrong. You just want to know if the apps you added are actually there. I fixed the test by first ordering the lists before comparing.
      
      AFAICT (and as far as that's relevant) the test got introduced in commit cb2a072e
      6ba93c2c
Loading