Skip to content
Snippets Groups Projects

Media uploader restyle

Merged Nastassia Danilova requested to merge fix/postStatusFormRestyling into master
All threads resolved!
  • wrong visibility select placement was fixed
  • I've reorganized media uploader and now it stores only uploaded files and shows them from url, instead of creating the image preview strangely. We don’t need to store separately media_ids and files anymore, just an array of uploaded media. In post status form we also can use the same Attachments component as for the gallery in status (just with trash button). Such markup helped to solve the problem when 'Add poll' button was moved away somehow after media uploading

Merge request reports

Approval is optional

Merged by Shpuld ShpludsonShpuld Shpludson 4 years ago (Jun 9, 2020 2:04pm UTC)

Merge details

  • Changes merged into with fc00cd9f.
  • Deleted the source branch.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • seems to work mostly fine now, although on desktop just adding one image stretches the post status form enough to give it a scroll bar, might want to adjust it a bit so that it doesn't happen

  • added 1 commit

    • 45e92dad - fix gallery height on media uploader mode

    Compare with previous version

  • Nastassia Danilova resolved all threads

    resolved all threads

  • mentioned in commit fc00cd9f

  • Please register or sign in to reply
    Loading