pleroma-elixir-libraries/bbcode
1
0
Fork 1
Code Issues Pull requests 3 Projects Releases Packages Wiki Activity

WIP: Fix various misparsing/crash issues #10

Draft
phnt wants to merge 6 commits from phnt/bbcode:various-fixes into master
pull from: phnt/bbcode:various-fixes
merge into: pleroma-elixir-libraries:master
Conversation 0 Commits 6 Files changed 3 +121 -13
phnt commented 2026-03-03 21:27:29 +00:00
Member
Copy link
  • Adds more tests for more free-form documents with unknown tags
  • Adds url/img tests to parser
  • Fixes NimbleParsec crash when parsing document with stray [, ]
  • Fixes NimbleParsec crash when parsing document with (unknown) closing-only brackets
  • Fixes NimbleParsec crash when parsing document with a pair of unknown tags
  • Makes end_tag strict and only match on valid tags, replaces lookahead_not(string("[/")) with lookahead_not(end_tag) as well

Superseeds !8

* Adds more tests for more free-form documents with unknown tags * Adds url/img tests to parser * Fixes NimbleParsec crash when parsing document with stray `[, ]` * Fixes NimbleParsec crash when parsing document with (unknown) closing-only brackets * Fixes NimbleParsec crash when parsing document with a pair of unknown tags * Makes `end_tag` strict and only match on valid tags, replaces `lookahead_not(string("[/"))` with `lookahead_not(end_tag)` as well Superseeds !8
Fixes parsing when "rest" only contains one bracket.
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u various-fixes:phnt-various-fixes
git switch phnt-various-fixes

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff phnt-various-fixes
git switch phnt-various-fixes
git rebase master
git switch master
git merge --ff-only phnt-various-fixes
git switch phnt-various-fixes
git rebase master
git switch master
git merge --no-ff phnt-various-fixes
git switch master
git merge --squash phnt-various-fixes
git switch master
git merge --ff-only phnt-various-fixes
git switch master
git merge phnt-various-fixes
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma-elixir-libraries/bbcode!10
No description provided.