pleroma-elixir-libraries/crypt
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

crypt.c: remove pragmas #1

Closed
normandy wants to merge 0 commits from gitlab-mr-iid-1 into fix/macos-arm64
pull from: gitlab-mr-iid-1
merge into: pleroma-elixir-libraries:fix/macos-arm64
Conversation 2 Commits - Files changed -
normandy commented 2021-07-16 05:38:33 +00:00
Member
Copy link

On some compilers, pragma messages are treated as a warning. If -Werror
is set, this would mean the compilation would erroneously fail.

On some compilers, pragma messages are treated as a warning. If -Werror is set, this would mean the compilation would erroneously fail.
lanodan commented 2021-07-16 17:54:15 +00:00
Owner
Copy link

Accepted but do note that mere -Werror should generaly be avoided as it has a lot of broken behavior and compilers tend to happily add warnings, using it for a category or precise warning like -Werror=format-security is fine though.

Accepted but do note that mere `-Werror` should generaly be avoided as it has a lot of broken behavior and compilers tend to happily add warnings, using it for a category or precise warning like `-Werror=format-security` is fine though.
normandy commented 2021-07-17 02:37:28 +00:00
Author
Member
Copy link

Agreed, though it does seem Mix does this by default, at least with MIX_ENV not set: https://git.pleroma.social/pleroma/pleroma/-/issues/2710

Not sure if that behaviour also occurs if MIX_ENV is set to prod explicitly but that can be discussed in that issue.

Agreed, though it does seem Mix does this by default, at least with `MIX_ENV` not set: https://git.pleroma.social/pleroma/pleroma/-/issues/2710 Not sure if that behaviour also occurs if `MIX_ENV` is set to `prod` explicitly but that can be discussed in that issue.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma-elixir-libraries/crypt!1
No description provided.