Existence of priv directory breaks Distillery releases

andyleclair commented

2020-08-17 20:55:28 +00:00

Member

Hello! I have been trying to use fast_html in a Distillery release and I believe I've found an issue caused by the existence of the priv directory. The elixir_make docs mention that the source code must not have a priv dir https://github.com/elixir-lang/elixir_make/blob/master/lib/mix/tasks/compile.make.ex#L94

I've got a working fork over at github, but the gist (pun intended) of the fix is:

Remove the priv directory
mkdir priv in Makefile, specifically the priv/fasthtml_worker target. After compiling lexbor but before compiling fasthtml_worker, simply mkdir priv

That should be enough to fix it. I've confirmed that my fork builds correctly and the compiled binary is reachable.

Hello! I have been trying to use fast_html in a Distillery release and I believe I've found an issue caused by the existence of the `priv` directory. The `elixir_make` docs mention that the source code must not have a `priv` dir https://github.com/elixir-lang/elixir_make/blob/master/lib/mix/tasks/compile.make.ex#L94 I've got a working fork over at github, but the gist (pun intended) of the fix is: * Remove the `priv` directory * `mkdir priv` in `Makefile`, specifically the `priv/fasthtml_worker` target. After compiling `lexbor` but before compiling `fasthtml_worker`, simply `mkdir priv` That should be enough to fix it. I've confirmed that my fork builds correctly and the compiled binary is reachable.

rinpatch commented

2020-08-19 11:50:29 +00:00

Member

@andyleclair I see, thanks for the report! Having priv dir in source was inherited from myhtmlex and I missed that point the docs when switching to elixir_make. Weird that it worked with Elixir's own OTP releases though. Since you already fixed the issue in your fork, do you mind submitting it in an MR here?

andyleclair commented

2020-08-19 13:33:08 +00:00

Author

Member

I can do that! I'll have to figure out how to do it, I'm sorta new to Gitlab.

rinpatch commented

2020-08-25 06:08:29 +00:00

Member

@andyleclair any updates?

rinpatch commented

2020-08-26 04:32:19 +00:00

Member

Closed by #34

Rows
Columns

Existence of priv directory breaks Distillery releases #9