pleroma-elixir-libraries/http_signatures
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity

OTP26 support #8

Closed
feld wants to merge 0 commits from gitlab-mr-iid-6 into master
pull from: gitlab-mr-iid-6
merge into: pleroma-elixir-libraries:master
Conversation 3 Commits - Files changed -
feld commented 2023-12-21 01:16:52 +00:00
Owner
Copy link

This fixes the test failure in Pleroma as the Map.keys/1 ordering is not guaranteed.

This fixes the test failure in Pleroma as the Map.keys/1 ordering is not guaranteed.
lanodan commented 2023-12-21 21:40:07 +00:00
Owner
Copy link

mix.lock shouldn't be committed in libraries as their only version constraints are in mix.exs.

`mix.lock` shouldn't be committed in libraries as their only version constraints are in `mix.exs`.
lambadalambda commented 2023-12-23 12:05:25 +00:00
Owner
Copy link

I'm not sure about that, see https://hexdocs.pm/elixir/main/library-guidelines.html#dependency-handling

I'm not sure about that, see https://hexdocs.pm/elixir/main/library-guidelines.html#dependency-handling
lanodan commented 2023-12-23 20:42:37 +00:00
Owner
Copy link

For very active libraries it could make sense to commit it, but for ones updated not even once a year like all our libraries I think it's better to consider the mix.lock as a SBOM that maybe CI could give as an artifact for reproducibility needs, rather than having it committed and end up with something that you'd need to remember to update everytime a modification is done, else it ends up being stuck in an old era which doesn't matches deployments.

For very active libraries it could make sense to commit it, but for ones updated not even once a year like all our libraries I think it's better to consider the `mix.lock` as a SBOM that maybe CI could give as an artifact for reproducibility needs, rather than having it committed and end up with something that you'd need to remember to update everytime a modification is done, else it ends up being stuck in an old era which doesn't matches deployments.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma-elixir-libraries/http_signatures!8
No description provided.